Chromium Code Reviews
Help | Chromium Project | Sign in
(769)

Issue 11363078: Add fast path for FastProperty objects in JSON.stringify. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by Yang
Modified:
2 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Add fast path for FastProperty objects in JSON.stringify. R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12853

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -23 lines) Patch
M src/json-stringifier.h View 1 1 chunk +55 lines, -23 lines 0 comments Download
M test/mjsunit/harmony/proxies-json.js View 1 chunk +22 lines, -0 lines 0 comments Download
M test/mjsunit/json2.js View 1 chunk +18 lines, -0 lines 0 comments Download
Trybot results:
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 2 (0 generated)
Yang
2 years, 9 months ago (2012-11-05 12:38:29 UTC) #1
Toon Verwaest
2 years, 9 months ago (2012-11-05 12:57:35 UTC) #2
lgtm if you add the IsDeleted() check. This should not happen right now anyway;
but just in case.

http://codereview.chromium.org/11363078/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

http://codereview.chromium.org/11363078/diff/1/src/json-stringifier.h#newcode581
src/json-stringifier.h:581: if (details.type() == FIELD && !map_changed) {
Also check for IsDeleted().
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f