Issue 11363078: Add fast path for FastProperty objects in JSON.stringify.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11363078: Add fast path for FastProperty objects in JSON.stringify. (Closed)

Created:
8 years, 1 month ago by Yang

Modified:
8 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add fast path for FastProperty objects in JSON.stringify. R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12853

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -23 lines)			Patch
M	src/json-stringifier.h	View	1	1 chunk	+55 lines, -23 lines	0 comments	Download
M	test/mjsunit/harmony/proxies-json.js	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	test/mjsunit/json2.js	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

8 years, 1 month ago (2012-11-05 12:57:35 UTC) #2

lgtm if you add the IsDeleted() check. This should not happen right now anyway;
but just in case.

http://codereview.chromium.org/11363078/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

http://codereview.chromium.org/11363078/diff/1/src/json-stringifier.h#newcode581
src/json-stringifier.h:581: if (details.type() == FIELD && !map_changed) {
Also check for IsDeleted().

Expand Messages | Collapse Messages