Create a new-installs-only uniformity trial.

Create a new-installs-only uniformity trial.

BUG=159210
TEST=No user visible changes.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166038

[SteveT, 2012-11-02 20:27:56]

Mind taking an initial look at this? Manual tests look good.

[Alexei Svitkine (slow), 2012-11-02 20:36:02]

https://codereview.chromium.org/11363062/diff/8001/chrome/browser/chrome_brow...
File chrome/browser/chrome_browser_field_trials.cc (right):

https://codereview.chromium.org/11363062/diff/8001/chrome/browser/chrome_brow...
chrome/browser/chrome_browser_field_trials.cc:247: // Setup a 50% uniformity
trial for new installs only. This is accomplished by
Nit: Perhaps make this a separate method.

https://codereview.chromium.org/11363062/diff/8001/chrome/browser/chrome_brow...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/11363062/diff/8001/chrome/browser/chrome_brow...
chrome/browser/chrome_browser_main.cc:578: int64 install_date =
local_state_->GetInt64(
nit: const

[SteveT, 2012-11-02 20:47:47]

Okay, done. Set the date to the 4th, so it would start on Sunday, should we land
this.

https://codereview.chromium.org/11363062/diff/8001/chrome/browser/chrome_brow...
File chrome/browser/chrome_browser_field_trials.cc (right):

https://codereview.chromium.org/11363062/diff/8001/chrome/browser/chrome_brow...
chrome/browser/chrome_browser_field_trials.cc:247: // Setup a 50% uniformity
trial for new installs only. This is accomplished by
On 2012/11/02 20:36:02, Alexei Svitkine wrote:
> Nit: Perhaps make this a separate method.

Done.

https://codereview.chromium.org/11363062/diff/8001/chrome/browser/chrome_brow...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/11363062/diff/8001/chrome/browser/chrome_brow...
chrome/browser/chrome_browser_main.cc:578: int64 install_date =
local_state_->GetInt64(
On 2012/11/02 20:36:02, Alexei Svitkine wrote:
> nit: const

Done.

[Alexei Svitkine (slow), 2012-11-02 20:59:58]

LGTM

[commit-bot: I haz the power, 2012-11-03 01:11:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/11363062/11002

[commit-bot: I haz the power, 2012-11-03 01:11:27]

Presubmit check for 11363062-11002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[SteveT, 2012-11-03 01:12:57]

+Scott for OWNERS rubberstamp.

[sky, 2012-11-05 15:24:06]

LGTM

[commit-bot: I haz the power, 2012-11-05 16:14:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/11363062/8006

[commit-bot: I haz the power, 2012-11-05 20:09:27]

Retried try job too often for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-05 20:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/11363062/8006

[commit-bot: I haz the power, 2012-11-05 21:36:44]

Change committed as 166038