Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11362240: Update the incognito NTP text for android (Closed)

Created:
8 years, 1 month ago by Ramya
Modified:
8 years, 1 month ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Update the incognito NTP text for android to use the shorter version. BUG=157721 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167855

Patch Set 1 #

Patch Set 2 : Update step failed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ramya
8 years, 1 month ago (2012-11-14 18:08:13 UTC) #1
Dan Beam
lgtm
8 years, 1 month ago (2012-11-14 20:15:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/11362240/1
8 years, 1 month ago (2012-11-14 21:18:10 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-14 21:24:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/11362240/3003
8 years, 1 month ago (2012-11-14 22:46:13 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-15 04:39:41 UTC) #6
Change committed as 167855

Powered by Google App Engine
This is Rietveld 408576698