android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java - Issue 11362183: [Android WebView] AwContentsClient.shouldCreateWindow callback part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java

Issue 11362183: [Android WebView] AwContentsClient.shouldCreateWindow callback part 1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase for landing Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java ('k') | android_webview/native/android_webview_jni_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java b/android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java

index 594b322ecbfdd083e6d9aefdc3275cfcfedc3c56..9245f7fd475d0290971f9bbb10a5673a715e81dd 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java

@@ -90,4 +90,9 @@ class NullContentsClient extends AwContentsClient {

public void onFormResubmission(Message dontResend, Message resend) {

dontResend.sendToTarget();

}

+ @Override

+ public boolean onCreateWindow(boolean isDialog, boolean isUserGesture) {

+ return false;

+ }

}