Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2215)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 11362183: [Android WebView] AwContentsClient.shouldCreateWindow callback part 1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase for landing Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
index 6ba07af7c2e5a17ee9a921805fdf098f11c20afa..03dab299791615dcc1bbdb0ff920f5ff3a1f3f28 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
@@ -136,6 +136,12 @@ public abstract class AwContentsClient extends ContentViewClient {
Message resend = mHandler.obtainMessage(CONTINUE_PENDING_RELOAD, contentViewCore);
AwContentsClient.this.onFormResubmission(dontResend, resend);
}
+
+ @Override
+ public boolean addNewContents(boolean isDialog, boolean isUserGesture) {
+ return AwContentsClient.this.onCreateWindow(isDialog, isUserGesture);
+ }
+
}
class AwWebContentsObserver extends WebContentsObserverAndroid {
@@ -215,6 +221,8 @@ public abstract class AwContentsClient extends ContentViewClient {
protected abstract void handleJsPrompt(String url, String message, String defaultValue,
JsPromptResultReceiver receiver);
+ protected abstract boolean onCreateWindow(boolean isDialog, boolean isUserGesture);
+
//--------------------------------------------------------------------------------------------
// Other WebView-specific methods
//--------------------------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698