content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 11362177: Replace VSyncMonitor with compositor's VSyncPulseMonitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 11362177: Replace VSyncMonitor with compositor's VSyncPulseMonitor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: findbugs Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/findbugs_filter/findbugs_known_bugs.txt ('k') | content/public/android/java/src/org/chromium/content/browser/VSyncMonitor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 97a72d57e7b2640f1491f85086cd13a52475c000..aa5956950fb1d677ff1cc82fe91b35127d6515a9 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -535,7 +535,7 @@ public class ContentViewCore implements MotionEventDelegate {

mImeAdapter = createImeAdapter(mContext);

mKeyboardConnected = mContainerView.getResources().getConfiguration().keyboard

!= Configuration.KEYBOARD_NOKEYS;

- mVSyncMonitor = new VSyncMonitor(mContext, mContainerView, mVSyncListener);

+ mVSyncMonitor = new VSyncMonitor(mContext, mVSyncListener);

TraceEvent.end();

}

@@ -588,12 +588,12 @@ public class ContentViewCore implements MotionEventDelegate {

public void destroy() {

hidePopupDialog();

+ if (mVSyncMonitor != null) mVSyncMonitor.unregisterListener();

if (mNativeContentViewCore != 0) {

nativeOnJavaContentViewCoreDestroyed(mNativeContentViewCore);

}

mNativeContentViewCore = 0;

mContentSettings = null;

- mVSyncMonitor.stop();

}

/**