Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 11362151: cc: Do not save the rasterScale for layers until they are finished animating transforms. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

cc: Do not save the rasterScale for layers until they are finished animating transforms. Currently we save the rasterScale for a layer the first time we see it. However, if the layer is animating, the value we save isn't very accurate. Instead, avoid saving the value until the animation is complete. Tests: cc_unittests:LayerTreeHostCommonTest.verifyContentsScaleForAnimatingLayer R=enne BUG=159937 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -38 lines) Patch
M cc/layer_animation_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/layer_tree_host_common.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M cc/test/animation_test_common.h View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/test/animation_test_common.cc View 4 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
8 years, 1 month ago (2012-11-08 02:13:48 UTC) #1
enne (OOO)
lgtm
8 years, 1 month ago (2012-11-08 02:37:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11362151/1
8 years, 1 month ago (2012-11-08 02:51:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11362151/1
8 years, 1 month ago (2012-11-08 11:39:13 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-08 11:53:28 UTC) #5
Change committed as 166660

Powered by Google App Engine
This is Rietveld 408576698