Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 11362130: [Android] Attach RenderWidgetHostView to ContentView at construction time. (Closed)

Created:
8 years, 1 month ago by gone
Modified:
8 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Attach RenderWidgetHostView to ContentView at construction time. Upstreaming of downstream CL. This handles the case where during ContentViewCore construction the WebContents being used does not have a RWHV yet and it matches other platforms where new windows in CreateViewForWidget() are shown by default. Original bugs:6937843,6931901 BUG=159063 TBR=ben Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
gone
Just upstreaming 4 lines of diff. Seems to help with rendering.
8 years, 1 month ago (2012-11-07 02:19:12 UTC) #1
no sievers
lgtm
8 years, 1 month ago (2012-11-07 02:24:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/11362130/1
8 years, 1 month ago (2012-11-07 18:36:56 UTC) #3
gone
TBRing ben since it's an Android change.
8 years, 1 month ago (2012-11-07 18:37:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/11362130/1
8 years, 1 month ago (2012-11-08 01:50:21 UTC) #5
commit-bot: I haz the power
Change committed as 166620
8 years, 1 month ago (2012-11-08 06:31:08 UTC) #6
Philippe
On 2012/11/08 06:31:08, I haz the power (commit-bot) wrote: > Change committed as 166620 I ...
8 years, 1 month ago (2012-11-08 18:10:06 UTC) #7
gone
On 2012/11/08 18:10:06, Philippe wrote: > On 2012/11/08 06:31:08, I haz the power (commit-bot) wrote: ...
8 years, 1 month ago (2012-11-08 22:22:28 UTC) #8
gone
8 years, 1 month ago (2012-11-08 23:06:01 UTC) #9
On 2012/11/08 22:22:28, dfalcantara wrote:
> On 2012/11/08 18:10:06, Philippe wrote:
> > On 2012/11/08 06:31:08, I haz the power (commit-bot) wrote:
> > > Change committed as 166620
> > 
> > I think this makes ~80 instrumentation tests fail :)
> > See
> >
>
http://build.chromium.org/p/chromium.fyi/builders/Android%252520Tests%252520%...
> > 
> > I did a bisect to track down this commit. Try r166619 (the commit before),
it
> > doesn't fail.
> 
> Reverted it, but this works downstream and worked when it was first submitted.

> Don't know why it's broken now, but it seems like a bad interaction with
> something that landed between this and Monday...

Found the other culprit:
https://chromiumcodereview.appspot.com/11366118

When both of these land together, everything explodes.  Haven't figured out why,
yet.

Powered by Google App Engine
This is Rietveld 408576698