Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4480)

Unified Diff: cc/thread_proxy.h

Issue 11362054: Use message passing for BeginFrameAndCommitState and clean up forced commit logic (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix windows signed/unsigned warning Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler_state_machine_unittest.cc ('k') | cc/thread_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/thread_proxy.h
diff --git a/cc/thread_proxy.h b/cc/thread_proxy.h
index 29832fc3ce23a193077f245b8382a1e6beda753b..e4fa901df168e3db213d9e6247c81f3891acb17c 100644
--- a/cc/thread_proxy.h
+++ b/cc/thread_proxy.h
@@ -80,7 +80,6 @@ public:
private:
ThreadProxy(LayerTreeHost*, scoped_ptr<Thread> implThread);
- // Set on impl thread, read on main thread.
struct BeginFrameAndCommitState {
BeginFrameAndCommitState();
~BeginFrameAndCommitState();
@@ -91,10 +90,9 @@ private:
PrioritizedResourceManager::BackingList evictedContentsTexturesBackings;
size_t memoryAllocationLimitBytes;
};
- scoped_ptr<BeginFrameAndCommitState> m_pendingBeginFrameRequest;
// Called on main thread
- void beginFrame();
+ void beginFrame(scoped_ptr<BeginFrameAndCommitState> beginFrameState);
void didCommitAndDrawFrame();
void didCompleteSwapBuffers();
void setAnimationEvents(scoped_ptr<AnimationEventsVector>, base::Time wallClockTime);
@@ -132,7 +130,6 @@ private:
bool m_animateRequested; // Set only when setNeedsAnimate is called.
bool m_commitRequested; // Set only when setNeedsCommit is called.
bool m_commitRequestSentToImplThread; // Set by setNeedsCommit and setNeedsAnimate.
- bool m_forcedCommitRequested;
base::CancelableClosure m_contextRecreationCallback;
LayerTreeHost* m_layerTreeHost;
bool m_rendererInitialized;
@@ -176,7 +173,7 @@ private:
size_t m_totalCommitCount;
bool m_deferCommits;
- bool m_deferredCommitPending;
+ scoped_ptr<BeginFrameAndCommitState> m_pendingDeferredCommit;
};
} // namespace cc
« no previous file with comments | « cc/scheduler_state_machine_unittest.cc ('k') | cc/thread_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698