Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 11362046: Tweak TCMalloc freelist pointer masking (Closed)

Created:
8 years, 1 month ago by jschuh
Modified:
8 years, 1 month ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Visibility:
Public.

Description

Tweak TCMalloc freelist pointer masking Previously I wasn't masking NULL freelist pointers because I didn't want to potentially leak address information. However, the branch for this is a hot point, and the leakage risk is still there for non-NULL known values. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/tcmalloc/chromium/src/free_list.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jschuh
Jim, the NULL pointer check doesn't really buy us much for security here (and has ...
8 years, 1 month ago (2012-11-06 18:32:43 UTC) #1
jar (doing other things)
lgtm
8 years, 1 month ago (2012-11-06 18:43:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/11362046/1
8 years, 1 month ago (2012-11-06 18:44:30 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-06 22:00:47 UTC) #4
Change committed as 166277

Powered by Google App Engine
This is Rietveld 408576698