Ensure that the foreground tab's process has high priority

Ensure that the foreground tab's process has high priority

To reclaim memory, Android will kill renderer processes before killing
the browser process (See
http://developer.android.com/guide/components/processes-and-threads.html).
That is, the browser process is a foreground process while the renderer
processes are service processes. A foreground process can bind to a
service process so that that process has the same priority as the
foreground process (in terms of what should be killed).

BUG=159980
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168007

[nilesh, 2012-11-14 19:23:18]

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:206:
content::NotificationService::AllBrowserContextsAndSources());
Is it possible to filter the notification by source?
( web_contents_->GetRenderViewHost()->GetProcess() )

It looks like the RenderProcessHost is created by now.

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:224: RenderWidgetHostImpl*
old_host =
Can we reuse some code from: GetCurrentRenderProcessId()
For eg. Create a common method GetRenderProcessIdFromRenderWidhgetHost() and use
at both places.

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:250: RenderProcessHost*
process = Source<RenderProcessHost>(source).ptr();
source_process_host

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:253: RenderProcessHost*
render_process =
current_process_host.
Also is it different from web_contents_->GetRenderViewHost()->GetProcess() ?

[cjhopman, 2012-11-15 01:21:43]

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:206:
content::NotificationService::AllBrowserContextsAndSources());
On 2012/11/14 19:23:18, nileshagrawal1 wrote:
> Is it possible to filter the notification by source?
> ( web_contents_->GetRenderViewHost()->GetProcess() )
> 
> It looks like the RenderProcessHost is created by now.
Filtering here does not seem to work. It seems that
web_contents_->GetRenderViewHost()->GetProcess() can change between this
registration and receiving the notification. I don't know enough about the
lifecycle of these things to really know what's happening, but everything else
that gets this notification also uses AllBrowserContextsAndSources.

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:224: RenderWidgetHostImpl*
old_host =
On 2012/11/14 19:23:18, nileshagrawal1 wrote:
> Can we reuse some code from: GetCurrentRenderProcessId()
> For eg. Create a common method GetRenderProcessIdFromRenderWidhgetHost() and
use
> at both places.

Done.

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:250: RenderProcessHost*
process = Source<RenderProcessHost>(source).ptr();
On 2012/11/14 19:23:18, nileshagrawal1 wrote:
> source_process_host

Done.

http://codereview.chromium.org/11361252/diff/2001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:253: RenderProcessHost*
render_process =
On 2012/11/14 19:23:18, nileshagrawal1 wrote:
> current_process_host.
> Also is it different from web_contents_->GetRenderViewHost()->GetProcess() ?

Done.

[nilesh, 2012-11-15 02:01:26]

LGTM with a minor fix.

http://codereview.chromium.org/11361252/diff/8001/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/11361252/diff/8001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:256:
web_contents_->getRenderViewHost()->GetProcess();
s/getRenderViewHost/GetRenderViewHost

[commit-bot: I haz the power, 2012-11-15 18:36:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11361252/1004

[commit-bot: I haz the power, 2012-11-15 20:26:44]

Change committed as 168007