Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Unified Diff: build/common.gypi

Issue 11361240: Add the -Wobjc-missing-property-synthesis flag. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: +mac Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 96e2fb79a55a8ab76b508638e2dccd4228544c8e..1e89ccdb015d2cf6a77b0e429e6737b694fab412 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3069,6 +3069,8 @@
'-Wall',
'-Wendif-labels',
'-Wextra',
+ # Warn if automatic synthesis is triggered.
+ '-Wobjc-missing-property-synthesis',
Nico 2012/11/14 21:06:55 If you say 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTH
Mark Mentovai 2012/11/15 00:06:52 There’s a symbolic name for this CLANG_WARN_OBJC_
# Don't warn about unused function parameters.
'-Wno-unused-parameter',
# Don't warn about the "struct foo f = {0};" initialization
@@ -3315,7 +3317,7 @@
# also seems to mean using the custom build of clang.
# Don't use -Wc++0x-extensions, which Xcode 4 enables by default
- # when buliding with clang. This warning is triggered when the
+ # when building with clang. This warning is triggered when the
# override keyword is used via the OVERRIDE macro from
# base/compiler_specific.h.
'CLANG_WARN_CXX0X_EXTENSIONS': 'NO',
@@ -3328,7 +3330,7 @@
'-Wno-unused-function',
# See comments on this flag higher up in this file.
'-Wno-unnamed-type-template-args',
- # This (rightyfully) complains about 'override', which we use
+ # This (rightfully) complains about 'override', which we use
# heavily.
'-Wno-c++11-extensions',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698