src/objects-inl.h - Issue 11361171: Make kAsciiDataHintTag have correct semantics for all both 1 and 2 byte string types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 11361171: Make kAsciiDataHintTag have correct semantics for all both 1 and 2 byte string types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index a88b83afeae62836764946ff30ef194f3526eb72..b7a3ced1630698ffd7218d3e9d33805da5c408d3 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -341,8 +341,7 @@ bool String::IsTwoByteRepresentationUnderneath() {

bool String::HasOnlyAsciiChars() {

uint32_t type = map()->instance_type();

- return (type & kStringEncodingMask) == kOneByteStringTag ||

- (type & kAsciiDataHintMask) == kAsciiDataHintTag;

+ return (type & kAsciiDataHintMask) == kAsciiDataHintTag;

}

« no previous file with comments | « src/objects.h ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »