Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 11361159: Importing the USB IDs database into third_party. (Closed)

Created:
8 years, 1 month ago by Garret Kelly
Modified:
8 years, 1 month ago
Reviewers:
open-source-third-party-reviews, bryeung, Daniel Berlin
CC:
chromium-reviews
Visibility:
Public.

Description

Importing the USB IDs database into third_party. BUG=127302 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17507 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/usb_ids/README.chromium View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/usb_ids/usb.ids View 1 chunk +17490 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Garret Kelly
Hello open-source-third-party-reviews, I'm trying to import this package into third_party. According to their site, it ...
8 years, 1 month ago (2012-11-07 23:45:55 UTC) #1
Daniel Berlin
LGTM Until they give an actual BSD license with acknowledgements they want, anything we do ...
8 years, 1 month ago (2012-11-12 20:48:20 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 1 month ago (2012-11-12 20:58:56 UTC) #3
bryeung
lgtm
8 years, 1 month ago (2012-11-12 21:06:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/11361159/1
8 years, 1 month ago (2012-11-12 21:07:20 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 02:07:02 UTC) #6
Change committed as 167283

Powered by Google App Engine
This is Rietveld 408576698