Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: chrome/browser/password_manager/password_manager.h

Issue 11361142: Fill passwords if password manager is disabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix lint warnings. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.h
diff --git a/chrome/browser/password_manager/password_manager.h b/chrome/browser/password_manager/password_manager.h
index 8a70585d1df4f0ac349ab597d916f9d3562a5d5d..1a457cced48e1f6750bc4c83e73a7f2b86a20bf6 100644
--- a/chrome/browser/password_manager/password_manager.h
+++ b/chrome/browser/password_manager/password_manager.h
@@ -84,9 +84,6 @@ class PasswordManager : public LoginModel,
private:
friend class content::WebContentsUserData<PasswordManager>;
- // Is password autofill enabled for the current profile?
- bool IsFillingEnabled() const;
-
// Note about how a PasswordFormManager can transition from
// pending_login_managers_ to provisional_save_manager_ and the infobar.
//
@@ -118,8 +115,8 @@ class PasswordManager : public LoginModel,
// The LoginModelObserver (i.e LoginView) requiring autofill.
LoginModelObserver* observer_;
- // Set to false to disable the password manager (will no longer fill
- // passwords or ask you if you want to save passwords).
+ // Set to false to disable the password manager (will no longer ask if you
+ // want to save passwords but continue to fill passwords).
Ilya Sherman 2012/11/08 06:11:26 nit: I think this would be slightly clearer if the
Timo Reimann 2012/11/08 13:36:06 Done.
BooleanPrefMember password_manager_enabled_;
DISALLOW_COPY_AND_ASSIGN(PasswordManager);

Powered by Google App Engine
This is Rietveld 408576698