Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4146)

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 11361142: Fill passwords if password manager is disabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make unit tests look consistent; add/extend in-code documentation. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index bf164fa9a5f3a04ce8bf7fb8dd6883a6118a109a..9646c3bdaf0978347033171954356ad3d10d97ce 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -121,7 +121,8 @@ void PasswordManager::SetFormHasGeneratedPassword(const PasswordForm& form) {
}
bool PasswordManager::IsSavingEnabled() const {
- return IsFillingEnabled() && !delegate_->GetProfile()->IsOffTheRecord();
+ return *password_manager_enabled_ &&
+ !delegate_->GetProfile()->IsOffTheRecord();
}
void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
@@ -222,9 +223,6 @@ bool PasswordManager::OnMessageReceived(const IPC::Message& message) {
void PasswordManager::OnPasswordFormsParsed(
const std::vector<PasswordForm>& forms) {
- if (!IsFillingEnabled())
- return;
-
// Ask the SSLManager for current security.
bool had_ssl_error = delegate_->DidLastPageLoadEncounterSSLErrors();
@@ -316,7 +314,3 @@ void PasswordManager::Autofill(
}
}
}
-
-bool PasswordManager::IsFillingEnabled() const {
- return delegate_->GetProfile() && *password_manager_enabled_;
-}
« no previous file with comments | « chrome/browser/password_manager/password_manager.h ('k') | chrome/browser/password_manager/password_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698