Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 11361056: Add structural support for building chrome_browser.gyp on iOS (Closed)

Created:
8 years, 1 month ago by stuartmorgan
Modified:
8 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add structural support for building chrome_browser.gyp on iOS This is not yet used, but helps lay the groundwork for building chrome/ targets for iOS. This uses exclude-all-and-include since Chrome for iOS uses only a subset of chrome/browser/, so the include list will be much more manageable and maintainable than an exclude list. BUG=156699 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165802

Patch Set 1 #

Patch Set 2 : Add common.gypi changes #

Patch Set 3 : Restore variations_seed_proto #

Total comments: 2

Patch Set 4 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -38 lines) Patch
M build/common.gypi View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 7 chunks +64 lines, -37 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
stuartmorgan
Almost there! After this I'll do chrome_tests.gypi, and then I can actually turn on a ...
8 years, 1 month ago (2012-11-02 08:03:40 UTC) #1
Nico
lgtm https://codereview.chromium.org/11361056/diff/3002/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/11361056/diff/3002/chrome/chrome_browser.gypi#newcode2205 chrome/chrome_browser.gypi:2205: 'xcode_settings': {'OTHER_LDFLAGS': ['-weak_framework CoreImage']}, Add "# CoreImage is ...
8 years, 1 month ago (2012-11-02 15:16:13 UTC) #2
Nico
lgtm
8 years, 1 month ago (2012-11-02 15:16:14 UTC) #3
stuartmorgan
https://codereview.chromium.org/11361056/diff/3002/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/11361056/diff/3002/chrome/chrome_browser.gypi#newcode2205 chrome/chrome_browser.gypi:2205: 'xcode_settings': {'OTHER_LDFLAGS': ['-weak_framework CoreImage']}, On 2012/11/02 15:16:13, Nico wrote: ...
8 years, 1 month ago (2012-11-02 15:27:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11361056/3003
8 years, 1 month ago (2012-11-02 15:28:35 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-02 15:34:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11361056/3003
8 years, 1 month ago (2012-11-02 15:40:57 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-02 16:20:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11361056/3003
8 years, 1 month ago (2012-11-02 16:35:42 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-02 16:42:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11361056/3003
8 years, 1 month ago (2012-11-02 17:18:54 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-02 17:35:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11361056/3003
8 years, 1 month ago (2012-11-02 19:45:24 UTC) #13
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-02 19:57:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11361056/3003
8 years, 1 month ago (2012-11-02 20:01:56 UTC) #15
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-02 21:35:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11361056/3003
8 years, 1 month ago (2012-11-02 21:42:00 UTC) #17
commit-bot: I haz the power
8 years, 1 month ago (2012-11-03 00:02:20 UTC) #18
Change committed as 165802

Powered by Google App Engine
This is Rietveld 408576698