Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: chrome/renderer/translate_helper.cc

Issue 11361051: Remove dependency on language detection library. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/translate_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/translate_helper.cc
diff --git a/chrome/renderer/translate_helper.cc b/chrome/renderer/translate_helper.cc
index e2d23bf25baec9cc2e0073ddbbb04ff4a782ede6..d2ae5efdef44b78121b91128269c032af86223c9 100644
--- a/chrome/renderer/translate_helper.cc
+++ b/chrome/renderer/translate_helper.cc
@@ -19,10 +19,13 @@
#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebScriptSource.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
-#include "third_party/cld/encodings/compact_lang_det/win/cld_unicodetext.h"
#include "v8/include/v8.h"
#include "webkit/glue/dom_operations.h"
+#if defined(ENABLE_LANGUAGE_DETECTION)
+#include "third_party/cld/encodings/compact_lang_det/win/cld_unicodetext.h"
+#endif
+
using WebKit::WebDocument;
using WebKit::WebElement;
using WebKit::WebFrame;
@@ -80,6 +83,7 @@ void TranslateHelper::PageCaptured(const string16& contents) {
TrimWhitespaceASCII(language, TRIM_ALL, &language);
language = StringToLowerASCII(language);
+#if defined(ENABLE_LANGUAGE_DETECTION)
if (language.empty()) {
base::TimeTicks begin_time = base::TimeTicks::Now();
language = DetermineTextLanguage(contents);
@@ -88,6 +92,10 @@ void TranslateHelper::PageCaptured(const string16& contents) {
} else {
VLOG(9) << "PageLanguageFromMetaTag: " << language;
}
+#else
+ if (language.empty())
+ return;
+#endif // defined(ENABLE_LANGUAGE_DETECTION)
Send(new ChromeViewHostMsg_TranslateLanguageDetermined(
routing_id(), language, IsPageTranslatable(&document)));
@@ -121,6 +129,7 @@ bool TranslateHelper::IsPageTranslatable(WebDocument* document) {
return true;
}
+#if defined(ENABLE_LANGUAGE_DETECTION)
// static
std::string TranslateHelper::DetermineTextLanguage(const string16& text) {
std::string language = chrome::kUnknownLanguageCode;
@@ -147,6 +156,7 @@ std::string TranslateHelper::DetermineTextLanguage(const string16& text) {
<< "\n*************************************\n";
return language;
}
+#endif // defined(ENABLE_LANGUAGE_DETECTION)
////////////////////////////////////////////////////////////////////////////////
// TranslateHelper, protected:
« no previous file with comments | « chrome/renderer/translate_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698