Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 11360251: Make kAsciiDataHintTag have correct semantics for all both 1 and 2 byte string types. (Closed)

Created:
8 years, 1 month ago by drcarney
Modified:
8 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Make kAsciiDataHintTag have correct semantics for all both 1 and 2 byte string types. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -46 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +17 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
drcarney
Okay, another attempt. I changed 1 instruction to 2 in the intel code-stubs files only ...
8 years, 1 month ago (2012-11-14 16:08:32 UTC) #1
Yang
8 years, 1 month ago (2012-11-15 10:28:32 UTC) #2
On 2012/11/14 16:08:32, dcarney wrote:
> Okay, another attempt. I changed 1 instruction to 2 in the intel code-stubs
> files only because I wasn't sure if I could better use that single instruction
> to shift 8 bits.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698