Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4134)

Unified Diff: build/android/pylib/android_commands.py

Issue 11360248: Use the new forwarder2's Daemon implementation in device_forwarder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Marcus' comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/forwarder.py » ('j') | tools/android/forwarder2/daemon.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/android_commands.py
diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py
index 65aab3c3333d6d3e43d1e793f5d15c9dec0f708e..aea334532f94fadf8dac754e21cccfa176518ad8 100644
--- a/build/android/pylib/android_commands.py
+++ b/build/android/pylib/android_commands.py
@@ -466,6 +466,17 @@ class AndroidCommands(object):
logging.info('\n>>> '.join(result))
return result
+ def GetShellCommandStatusAndOutput(self, command, timeout_time=20,
+ log_result=False):
+ """See RunShellCommand() above.
+
+ Returns:
+ The tuple (exit code, list of output lines).
+ """
+ lines = self.RunShellCommand(
+ command + '; echo $?', timeout_time, log_result)
digit1 2012/11/19 15:27:43 Nit: This assumes that the command's output will b
Philippe 2012/11/19 17:18:59 Good point.
+ return (int(lines[-1]), lines[:-1])
+
def KillAll(self, process):
"""Android version of killall, connected via adb.
« no previous file with comments | « no previous file | build/android/pylib/forwarder.py » ('j') | tools/android/forwarder2/daemon.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698