Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 11360194: Bring up minimal sync and sync unittest targets on iOS. (Closed)

Created:
8 years, 1 month ago by blundell
Modified:
8 years, 1 month ago
Reviewers:
Nicolas Zea, qsr
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing), stuartmorgan
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Bring up minimal sync and sync unittest targets on iOS. The sync implementation is not yet complete (e.g., there is not yet an invalidator_factory implementation on iOS), but enough of the structure is in place to allow for the sync target to build and a reduced set of unittests to run successfully. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167485

Patch Set 1 #

Total comments: 8

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -3 lines) Patch
M build/all.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M sync/sync.gyp View 4 chunks +24 lines, -2 lines 0 comments Download
M sync/util/get_session_name.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A sync/util/get_session_name_ios.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
A sync/util/get_session_name_ios.mm View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
blundell
8 years, 1 month ago (2012-11-12 16:11:45 UTC) #1
qsr
http://codereview.chromium.org/11360194/diff/1/sync/util/get_session_name_ios.h File sync/util/get_session_name_ios.h (right): http://codereview.chromium.org/11360194/diff/1/sync/util/get_session_name_ios.h#newcode1 sync/util/get_session_name_ios.h:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
8 years, 1 month ago (2012-11-13 10:58:12 UTC) #2
blundell
Thanks. +zea for OWNERS. https://chromiumcodereview.appspot.com/11360194/diff/1/sync/util/get_session_name_ios.h File sync/util/get_session_name_ios.h (right): https://chromiumcodereview.appspot.com/11360194/diff/1/sync/util/get_session_name_ios.h#newcode1 sync/util/get_session_name_ios.h:1: // Copyright (c) 2012 The ...
8 years, 1 month ago (2012-11-13 14:07:42 UTC) #3
Nicolas Zea
lgtm
8 years, 1 month ago (2012-11-13 17:43:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/11360194/7
8 years, 1 month ago (2012-11-13 19:44:41 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 22:23:56 UTC) #6
Change committed as 167485

Powered by Google App Engine
This is Rietveld 408576698