Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: update_depot_tools

Issue 11360150: Improve error message when gclient can't update (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: update_depot_tools
diff --git a/update_depot_tools b/update_depot_tools
index fe36f0b28ae29781824cfff197936bcf4640831c..dc58e5211fc8711adcae0976873a25a09f700408 100755
--- a/update_depot_tools
+++ b/update_depot_tools
@@ -69,9 +69,15 @@ function is_git_clone_repo {
function update_git_repo {
if is_git_clone_repo; then
- git fetch -q origin > /dev/null
- git rebase -q origin/master > /dev/null
- return 0
+ git fetch -q origin &> /dev/null
+ local REBASE_TXT=$(git rebase -q origin/master 2>&1)
+ local STATUS=$?
+ if [[ $STATUS != 0 ]]; then
+ echo "depot_tools update failed. Conflict in $base_dir" >&2
+ echo "$REBASE_TXT" >&2
+ git rebase --abort 2> /dev/null
+ fi
+ return $STATUS
fi
test_git_svn
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698