Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: content/renderer/browser_plugin/browser_plugin_browsertest.cc

Issue 11360106: Browser Plugin: Implement AutoSize (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with ToT Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_browsertest.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_browsertest.cc b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
index 723aa8e383fcbbfd09bf775447df8d67485eabea..da98876f0f7c3c236d7a95a697086b46f91aabcf 100644
--- a/content/renderer/browser_plugin/browser_plugin_browsertest.cc
+++ b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
@@ -667,10 +667,10 @@ TEST_F(BrowserPluginTest, AutoSizeAttributes) {
&create_instance_id,
&params);
EXPECT_TRUE(params.auto_size.enable);
- EXPECT_EQ(42, params.auto_size.min_width);
- EXPECT_EQ(43, params.auto_size.min_height);
- EXPECT_EQ(1337, params.auto_size.max_width);
- EXPECT_EQ(1338, params.auto_size.max_height);
+ EXPECT_EQ(42, params.auto_size.min_size.width());
+ EXPECT_EQ(43, params.auto_size.min_size.height());
+ EXPECT_EQ(1337, params.auto_size.max_size.width());
+ EXPECT_EQ(1338, params.auto_size.max_size.height());
}
// Disable autosize and verify that the BrowserPlugin issues a
// BrowserPluginHostMsg_SetAutoSize with the change.
@@ -682,17 +682,16 @@ TEST_F(BrowserPluginTest, AutoSizeAttributes) {
BrowserPluginHostMsg_SetAutoSize::ID);
ASSERT_TRUE(auto_size_msg);
- int instance_id;
- BrowserPluginHostMsg_AutoSize_Params params;
- BrowserPluginHostMsg_SetAutoSize::Read(
- auto_size_msg,
- &instance_id,
- &params);
- EXPECT_FALSE(params.enable);
- EXPECT_EQ(42, params.min_width);
- EXPECT_EQ(43, params.min_height);
- EXPECT_EQ(1337, params.max_width);
- EXPECT_EQ(1338, params.max_height);
+ PickleIterator iter = IPC::SyncMessage::GetDataIterator(auto_size_msg);
+ BrowserPluginHostMsg_SetAutoSize::SendParam set_auto_size_params;
+ ASSERT_TRUE(IPC::ReadParam(auto_size_msg, &iter, &set_auto_size_params));
+ const BrowserPluginHostMsg_AutoSize_Params& auto_size_params =
+ set_auto_size_params.b;
+ EXPECT_FALSE(auto_size_params.enable);
+ EXPECT_EQ(42, auto_size_params.min_size.width());
+ EXPECT_EQ(43, auto_size_params.min_size.height());
+ EXPECT_EQ(1337, auto_size_params.max_size.width());
+ EXPECT_EQ(1338, auto_size_params.max_size.height());
}
}

Powered by Google App Engine
This is Rietveld 408576698