Browser Plugin: Implement AutoSize

content/browser/renderer_host/render_view_host_impl.cc

Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 19ddc20c593639086de0675ad7b0b35c47ed898b..7d5b349a2010ff02f5360d0757ae9def99d62a6e 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -928,6 +928,7 @@ bool RenderViewHostImpl::OnMessageReceived(const IPC::Message& msg) {
   // thread and make these messages async: http://crbug.com/149063.
   if (msg.type() != BrowserPluginHostMsg_HandleInputEvent::ID &&
       msg.type() != BrowserPluginHostMsg_ResizeGuest::ID &&
+      msg.type() != BrowserPluginHostMsg_SetAutoSize::ID &&

[jam, 2012/11/09 17:11:10]

anyway to avoid this sync IPC?

[Fady Samuel, 2012/11/09 17:41:10]

Yes, but not easily. We have a bug open related to this:

http://code.google.com/p/chromium/issues/detail?id=155915

The major issue is we need to share a buffer between two processes and we need
to make sure that both processes are aware of the new buffer prior to using it.
Using a SYNC IPC is the easy way to do this.

Coordinating this via async messages is certainly possible, but quite a bit
harder to get right.

[Fady Samuel, 2012/11/09 18:02:53]

As per offline discussion, this is a hard, general problem that needs to be
fixed for resize (auto or otherwise). We will address this for M25, in a
separate patch.

       !BrowserMessageFilter::CheckCanDispatchOnUI(msg, this))
     return true;