tools/checklicenses/checklicenses.py - Issue 11360098: Roll third_party/pexpect 509:533

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/checklicenses/checklicenses.py

Issue 11360098: Roll third_party/pexpect 509:533 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase after licensecheck.pl Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/checklicenses/checklicenses.py

diff --git a/tools/checklicenses/checklicenses.py b/tools/checklicenses/checklicenses.py

index 193efd7afbc9ade6bfc03b87ef2fdae2313dc6eb..63f4e7d497ecd0e589cac543f74338cfdf17f60f 100755

--- a/tools/checklicenses/checklicenses.py

+++ b/tools/checklicenses/checklicenses.py

@@ -332,9 +332,6 @@ PATH_SPECIFIC_WHITELISTED_LICENSES = {

'third_party/ply/__init__.py': [

'UNKNOWN',

- 'third_party/pexpect': [ # http://crbug.com/156113

Paweł Hajdan Jr. 2012/11/08 17:42:04 Yay, removing an excpetion. Awesome!

bulach 2012/11/08 17:45:36 :)

- 'UNKNOWN',

- ],

'third_party/protobuf': [ # http://crbug.com/98455

'UNKNOWN',

@@ -455,7 +452,9 @@ def check_licenses(options, args):

'devscripts',

'licensecheck.pl'))

- licensecheck = subprocess.Popen([licensecheck_path, '-r', start_dir],

+ licensecheck = subprocess.Popen([licensecheck_path,

+ '-l', '100',

Paweł Hajdan Jr. 2012/11/08 17:42:04 Just checking: do you need this? If so, OK.

bulach 2012/11/08 17:45:36 yes, this is needed: sorry, I forgot to update the

+ '-r', start_dir],

stdout=subprocess.PIPE,

stderr=subprocess.PIPE)

stdout, stderr = licensecheck.communicate()

« no previous file with comments | « third_party/pexpect/screen.py ('k') | no next file » | no next file with comments »