Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2032)

Unified Diff: chrome/browser/autofill/autofill_ie_toolbar_import_win.cc

Issue 11360055: [Autofill] Rename GetInfo and SetInfo to GetRawInfo and SetRawInfo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix names in more tests Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_ie_toolbar_import_win.cc
diff --git a/chrome/browser/autofill/autofill_ie_toolbar_import_win.cc b/chrome/browser/autofill/autofill_ie_toolbar_import_win.cc
index 41da6c0b12f783ce5896fb1f179f3e56ff0d4854..90df89cdc25346a00b78f76effe82648154e477a 100644
--- a/chrome/browser/autofill/autofill_ie_toolbar_import_win.cc
+++ b/chrome/browser/autofill/autofill_ie_toolbar_import_win.cc
@@ -148,10 +148,11 @@ bool ImportSingleProfile(FormGroup* profile,
if (it->second == CREDIT_CARD_NUMBER)
field_value = DecryptCCNumber(field_value);
+ // TODO(isherman): Call SetCanonicalizedInfo below, rather than SetRawInfo
Dan Beam 2012/11/09 18:46:30 nit: .
Ilya Sherman 2012/11/10 03:21:33 Done.
// We need to store phone data in |phone| before building the whole number
// at the end. The rest of the fields are set "as is".
if (!phone.SetInfo(it->second, field_value))
- profile->SetInfo(it->second, field_value);
+ profile->SetRawInfo(it->second, field_value);
}
}
// Now re-construct the phones if needed.
@@ -255,7 +256,9 @@ bool ImportCurrentUserProfiles(std::vector<AutofillProfile>* profiles,
RegKey key(HKEY_CURRENT_USER, key_name.c_str(), KEY_READ);
CreditCard credit_card;
if (ImportSingleProfile(&credit_card, &key, reg_to_field)) {
- string16 cc_number = credit_card.GetInfo(CREDIT_CARD_NUMBER);
+ // TODO(isherman): Call into GetCanonicalizedInfo() below, rather than
+ // GetRawInfo().
+ string16 cc_number = credit_card.GetRawInfo(CREDIT_CARD_NUMBER);
if (!cc_number.empty())
credit_cards->push_back(credit_card);
}
@@ -272,4 +275,3 @@ bool ImportAutofillDataWin(PersonalDataManager* pdm) {
// importer will self delete.
return importer->ImportProfiles();
}
-

Powered by Google App Engine
This is Rietveld 408576698