[Autofill] Rename GetInfo and SetInfo to GetRawInfo and SetRawInfo

[Autofill] Rename GetInfo and SetInfo to GetRawInfo and SetRawInfo

This is part 1 of a multi-CL change to always read the application locale from
an appropriate thread in the Autofill code.  The next CL will rename
GetCanonicalizedInfo and SetCanonicalizedInfo to GetInfo and SetInfo, and add a
|locale| parameter to these methods.  Subsequent CLs will migrate all Autofill
code that currently access the locale to always access it from the UI thread.

BUG=100845
TEST=none (pure refactoring)

TBR=dhollowa@chromium.org, akalin@chromium.org, bauerb@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167072

[Ilya Sherman, 2012-11-02 06:46:43]

David, I'm hoping you won't mind too much reviewing this and the subsequent CLs
for this bug.  For context (also mentioned in the CL description), I'm trying to
fix the long-standing bug where we sometimes access the application locale from
an unsafe thread, which can cause crashes due to racing on shutdown.

This is the first CL in that series, and simply renames a couple of FormGroup
methods.  These methods are currently named to seem as though they should be the
default choice between these and the "Canonicalized" versions; but in fact,
these should only ever be called when comparing or copying existing profile
data.

In the next CL, I'll rename the "Canonicalized" methods to SetInfo and GetInfo. 
I wanted to do that in a separate CL both to make these large CLs easier to
verify, and to make sure that there are no existing uses of SetInfo and GetInfo
that I missed.

The reason that I'd like you to review these CLs is that they're going to get
somewhat more involved (but smaller!) down the line, and I think you are in the
best position to be aware of what subtleties to watch out for.  Thanks in
advance!

[Ilya Sherman, 2012-11-08 07:43:00]

After working more on the subsequent CLs in this series, I realized that we
don't actually need very tricky changes to fix things here.  Hence, re-assigning
the review to Dan (thanks, Dan!)

[Dan Beam, 2012-11-09 18:46:30]

rs lgtm w/nits (it's just basically a rename, right?)

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
File chrome/browser/autofill/autofill_ie_toolbar_import_win.cc (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
chrome/browser/autofill/autofill_ie_toolbar_import_win.cc:151: //
TODO(isherman): Call SetCanonicalizedInfo below, rather than SetRawInfo
nit: .

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
File chrome/browser/autofill/autofill_profile.cc (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
chrome/browser/autofill/autofill_profile.cc:325: << "Attempt to set multiple
values on single-valued field.";
nit: remove string?

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
chrome/browser/autofill/autofill_profile.cc:572: StringToLowerASCII(new_value))
nit: curlies

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
File chrome/browser/autofill/personal_data_manager_mac.mm (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
chrome/browser/autofill/personal_data_manager_mac.mm:187:
profile->SetRawInfo(ADDRESS_HOME_CITY, base::SysNSStringToUTF16(city));
nit: I find \n after if () statements more readable

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/ui/web...
File chrome/browser/ui/webui/options/autofill_options_handler.cc (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/ui/web...
chrome/browser/ui/webui/options/autofill_options_handler.cc:559:
profile.SetRawInfo(COMPANY_NAME, value);
same nit re: \n after if

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/ui/web...
chrome/browser/ui/webui/options/autofill_options_handler.cc:598: if
(args->GetString(1, &value))
and here

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/webdat...
File chrome/browser/webdata/autofill_profile_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/webdat...
chrome/browser/webdata/autofill_profile_syncable_service.cc:340: for (size_t i =
0; i < values.size(); ++i)
nit: curlies, IMO, and/or at least a \n under these for loops as my eyes
originally thought there was an indent error

[Ilya Sherman, 2012-11-10 03:21:33]

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
File chrome/browser/autofill/autofill_ie_toolbar_import_win.cc (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
chrome/browser/autofill/autofill_ie_toolbar_import_win.cc:151: //
TODO(isherman): Call SetCanonicalizedInfo below, rather than SetRawInfo
On 2012/11/09 18:46:30, Dan Beam wrote:
> nit: .

Done.

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
File chrome/browser/autofill/autofill_profile.cc (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
chrome/browser/autofill/autofill_profile.cc:325: << "Attempt to set multiple
values on single-valued field.";
On 2012/11/09 18:46:30, Dan Beam wrote:
> nit: remove string?

Done.

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
chrome/browser/autofill/autofill_profile.cc:572: StringToLowerASCII(new_value))
On 2012/11/09 18:46:30, Dan Beam wrote:
> nit: curlies

Done.

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
File chrome/browser/autofill/personal_data_manager_mac.mm (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/autofi...
chrome/browser/autofill/personal_data_manager_mac.mm:187:
profile->SetRawInfo(ADDRESS_HOME_CITY, base::SysNSStringToUTF16(city));
On 2012/11/09 18:46:30, Dan Beam wrote:
> nit: I find \n after if () statements more readable

Done.

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/ui/web...
File chrome/browser/ui/webui/options/autofill_options_handler.cc (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/ui/web...
chrome/browser/ui/webui/options/autofill_options_handler.cc:559:
profile.SetRawInfo(COMPANY_NAME, value);
On 2012/11/09 18:46:30, Dan Beam wrote:
> same nit re: \n after if

Done.

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/ui/web...
chrome/browser/ui/webui/options/autofill_options_handler.cc:598: if
(args->GetString(1, &value))
On 2012/11/09 18:46:30, Dan Beam wrote:
> and here

Done.

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/webdat...
File chrome/browser/webdata/autofill_profile_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/11360055/diff/35/chrome/browser/webdat...
chrome/browser/webdata/autofill_profile_syncable_service.cc:340: for (size_t i =
0; i < values.size(); ++i)
On 2012/11/09 18:46:30, Dan Beam wrote:
> nit: curlies, IMO, and/or at least a \n under these for loops as my eyes
> originally thought there was an indent error

Done.

[commit-bot: I haz the power, 2012-11-10 03:22:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/11360055/4013

[commit-bot: I haz the power, 2012-11-10 03:23:02]

Presubmit check for 11360055-4013 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/browsing_data
    chrome/browser/sync
    chrome/browser/webdata

Presubmit checks took 4.7s to calculate.

[Ilya Sherman, 2012-11-10 03:26:46]

TBR'ing reviewers, since this is just a rename.

[commit-bot: I haz the power, 2012-11-10 03:27:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/11360055/4013

[commit-bot: I haz the power, 2012-11-10 06:31:20]

Change committed as 167072