Add a 'NACL' plugin type to PepperMessageFilter so we can block private APIs.

Add a 'NACL' plugin type to PepperMessageFilter so we can block private APIs.
The new NaCl IPC proxy is out of process and should not allow untrusted code
to use sockets.
BUG=116317
TEST=browser_tests, --gtest_filter=PPAPINaClTest*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165606

[piman, 2012-11-01 23:34:41]

LGTM+nit

http://codereview.chromium.org/11360052/diff/1/content/browser/pepper_helper.cc
File content/browser/pepper_helper.cc (right):

http://codereview.chromium.org/11360052/diff/1/content/browser/pepper_helper....
content/browser/pepper_helper.cc:13: void
EnablePepperSupportForChannel(IPC::ChannelProxy* channel,
nit: I never realized this was for NaCl only. Should the name reflect that?

[bbudge, 2012-11-01 23:48:54]

On 2012/11/01 23:34:41, piman wrote:
> LGTM+nit
> 
>
http://codereview.chromium.org/11360052/diff/1/content/browser/pepper_helper.cc
> File content/browser/pepper_helper.cc (right):
> 
>
http://codereview.chromium.org/11360052/diff/1/content/browser/pepper_helper....
> content/browser/pepper_helper.cc:13: void
> EnablePepperSupportForChannel(IPC::ChannelProxy* channel,
> nit: I never realized this was for NaCl only. Should the name reflect that?

This is going away in an upcoming patch. We also need to create a
BrowserPpapiHost for NaCl, and I will move this bit of code into
BrowserPpapiHostImpl (and delete PepperHelper). We call clients of this
'External' plugins. Though NaCl is currently the only example of an external
plugin, NaCl isn't really supposed to be a concept in 'content'.

[commit-bot: I haz the power, 2012-11-01 23:49:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/11360052/1

[bbudge, 2012-11-01 23:49:44]

http://codereview.chromium.org/11360052/diff/1/content/browser/pepper_helper.cc
File content/browser/pepper_helper.cc (right):

http://codereview.chromium.org/11360052/diff/1/content/browser/pepper_helper....
content/browser/pepper_helper.cc:13: void
EnablePepperSupportForChannel(IPC::ChannelProxy* channel,
On 2012/11/01 23:34:41, piman wrote:
> nit: I never realized this was for NaCl only. Should the name reflect that?
See comment.

[commit-bot: I haz the power, 2012-11-02 02:54:15]

Change committed as 165606