Issue 11360026: Add the "file_handlers" manifest key for platform apps to replace "intents".

Issue 11360026: Add the "file_handlers" manifest key for platform apps to replace "intents". (Closed)

Created:
8 years, 1 month ago by jeremya

Modified:
8 years, 1 month ago

Reviewers:
benwells, James Hawkins

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, tapted, koz (OOO until 15th September)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add the "file_handlers" manifest key for platform apps to replace "intents". This patch just adds a synonym for the "intents" functionality, but the eventual intention is to remove the intents code from extensions altogether. R=benwells@chromium.org,jhawkins@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165628

Patch Set 1 #

Total comments: 8

Patch Set 2 : nits #

Patch Set 3 : fix tests #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -59 lines)			Patch
M	chrome/browser/extensions/platform_app_browsertest.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser_tests.isolate	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/_manifest_features.json	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1	4 chunks	+70 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_manifest_constants.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_manifest_constants.cc	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/get_display_path/manifest.json	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_file/manifest.json	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_invalid/manifest.json	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_nothing/manifest.json	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_reply/manifest.json	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
D	chrome/test/data/extensions/platform_apps/launch_wrong_intent/manifest.json	View		1 chunk	+0 lines, -17 lines	0 comments	Download
D	chrome/test/data/extensions/platform_apps/launch_wrong_intent/test.js	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/launch_wrong_type/manifest.json	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

benwells

lgtm with some nits. https://codereview.chromium.org/11360026/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): https://codereview.chromium.org/11360026/diff/1/chrome/common/extensions/extension.cc#newcode2119 chrome/common/extensions/extension.cc:2119: service.action = ASCIIToUTF16("http://webintents.org/view"); Add a ...

8 years, 1 month ago (2012-11-01 04:00:55 UTC) #2

jeremya

https://codereview.chromium.org/11360026/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): https://codereview.chromium.org/11360026/diff/1/chrome/common/extensions/extension.cc#newcode2119 chrome/common/extensions/extension.cc:2119: service.action = ASCIIToUTF16("http://webintents.org/view"); On 2012/11/01 04:00:55, benwells wrote: > ...

8 years, 1 month ago (2012-11-01 04:21:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/11360026/6001

8 years, 1 month ago (2012-11-01 23:26:48 UTC) #5

commit-bot: I haz the power

Retried try job too often for step(s) browser_tests

8 years, 1 month ago (2012-11-02 01:19:04 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/11360026/5003

8 years, 1 month ago (2012-11-02 02:24:19 UTC) #7

Change committed as 165628

Expand Messages | Collapse Messages