Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 11359222: Break path whereby AssociatedURLLoader::~AssociatedURLLoader() is re-entered on top of itself. (Closed)

Created:
8 years, 1 month ago by Tom Sepez
Modified:
8 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Break path whereby AssociatedURLLoader::~AssociatedURLLoader() is re-entered on top of itself. BUG=159429 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168150

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webkit/plugins/ppapi/ppb_url_loader_impl.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tom Sepez
Hey brett, please review or suggest an appropriate alternate.
8 years, 1 month ago (2012-11-15 01:43:57 UTC) #1
brettw
lgtm
8 years, 1 month ago (2012-11-15 23:42:54 UTC) #2
Tom Sepez
Brett, Here's an alternate implementation, maybe less kludgy. Let me know if its better.
8 years, 1 month ago (2012-11-15 23:56:28 UTC) #3
brettw
Let's use the first one. I think this problem will go away when I convert ...
8 years, 1 month ago (2012-11-15 23:59:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/11359222/6003
8 years, 1 month ago (2012-11-16 02:06:48 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-16 07:35:56 UTC) #6
Change committed as 168150

Powered by Google App Engine
This is Rietveld 408576698