Issue 11359215: Ensure parent id added only when we need an identifier for the child

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11359215: Ensure parent id added only when we need an identifier for the child (Closed)

Created:
8 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
8 years, 1 month ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dart-web-components.git@master

Visibility:
Public.

Ensure parent made explicit only when we need an identifier for the child Also start using unified diff. Committed: https://github.com/dart-lang/dart-web-components/commit/fdcbf59

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -16 lines)			Patch
M	lib/src/analyzer.dart	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	pubspec.yaml	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/run.sh	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

lgtm. thank you!