Chromium Code Reviews
Help | Chromium Project | Sign in
(354)

Issue 11359215: Ensure parent id added only when we need an identifier for the child (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Siggi Cherem (dart-lang)
Modified:
1 year, 5 months ago
Reviewers:
John Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart-web-components.git@master
Visibility:
Public.

Description

Ensure parent made explicit only when we need an identifier for the child

Also start using unified diff.

Committed: https://github.com/dart-lang/dart-web-components/commit/fdcbf59

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Lint Patch
M lib/src/analyzer.dart View 2 chunks +9 lines, -8 lines 0 comments ? errors Download
M pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/run.sh View 1 1 chunk +3 lines, -7 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Siggi Cherem (dart-lang)
1 year, 5 months ago #1
Siggi Cherem (dart-lang)
(tbr)
1 year, 5 months ago #2
John Messerly
1 year, 5 months ago #3
lgtm. thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434