Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 11359212: Fix clang build after r12956 (Closed)

Created:
8 years, 1 month ago by adamk
Modified:
8 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev, Sven Panne, Jakob Kummerow
Visibility:
Public.

Description

Fix clang build after r12956 That change added a test which called the handlified version of JSObject::SetElement and didn't check the return value, but that method has a MUST_USE_RESULT annotation. This change removes the annotation for consistency with other handlified static methods (like SetProperty). Committed: https://code.google.com/p/v8/source/detail?r=12963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
8 years, 1 month ago (2012-11-14 18:40:35 UTC) #1
Yang
On 2012/11/14 18:40:35, adamk wrote: I'd prefer using the USE macro at the point where ...
8 years, 1 month ago (2012-11-14 20:01:32 UTC) #2
Yang
On 2012/11/14 20:01:32, Yang wrote: > On 2012/11/14 18:40:35, adamk wrote: > > I'd prefer ...
8 years, 1 month ago (2012-11-14 20:02:46 UTC) #3
adamk
8 years, 1 month ago (2012-11-14 20:04:34 UTC) #4
On 2012/11/14 20:01:32, Yang wrote:
> On 2012/11/14 18:40:35, adamk wrote:
> 
> I'd prefer using the USE macro at the point where the return value is not used
> (the test you mentioned). Would that be viable?

Seems unnecessary to force people to use the result if it's a handle; as I said,
that's not consistent with other handlified methods. I assumed the reason for
MUST_USE_RESULTs in objects.h was for functions that could return GC Failures.

Powered by Google App Engine
This is Rietveld 408576698