Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1690)

Unified Diff: content/renderer/media/audio_device_factory.h

Issue 11359196: Associate audio streams with their source/destination RenderView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Plus, removed CalledOnValidThread DCHECK from sampleRate() call since nothing mutates. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/media/audio_device_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_device_factory.h
diff --git a/content/renderer/media/audio_device_factory.h b/content/renderer/media/audio_device_factory.h
index e95e487e88a95acc4f97077ac84206cd864d7c2f..b06ace7aea31af2d27f23ac0b1570c55538151f0 100644
--- a/content/renderer/media/audio_device_factory.h
+++ b/content/renderer/media/audio_device_factory.h
@@ -6,29 +6,26 @@
#define CONTENT_RENDERER_MEDIA_AUDIO_DEVICE_FACTORY_H_
#include "base/basictypes.h"
-#include "content/common/content_export.h"
+#include "base/memory/ref_counted.h"
namespace media {
class AudioInputDevice;
-class AudioRendererSink;
}
namespace content {
-// A factory for creating AudioRendererSinks. There is a global factory
+class RendererAudioOutputDevice;
+
+// A factory for creating RendererAudioOutputDevices. There is a global factory
// function that can be installed for the purposes of testing to provide
// a specialized AudioRendererSink class.
-class CONTENT_EXPORT AudioDeviceFactory {
+class AudioDeviceFactory {
public:
- // Creates an AudioRendererSink using the currently registered factory,
- // or the default one if no factory is registered. Ownership of the returned
- // pointer will be passed to the caller.
- static media::AudioRendererSink* NewOutputDevice();
+ // Creates a RendererAudioOutputDevice using the currently registered factory.
+ static scoped_refptr<RendererAudioOutputDevice> NewOutputDevice();
- // TODO(henrika): Update AudioInputDevice to inherit from an interface
- // similar to AudioRendererSink, but for input. Same for the callback
- // interfaces.
- static media::AudioInputDevice* NewInputDevice();
+ // Creates an AudioInputDevice using the currently registered factory,
+ static scoped_refptr<media::AudioInputDevice> NewInputDevice();
protected:
AudioDeviceFactory();
@@ -38,7 +35,7 @@ class CONTENT_EXPORT AudioDeviceFactory {
// functions to provide alternate audio device implementations.
// If the return value of either of these function is NULL, we fall back
// on the default implementation.
- virtual media::AudioRendererSink* CreateOutputDevice() = 0;
+ virtual RendererAudioOutputDevice* CreateOutputDevice() = 0;
virtual media::AudioInputDevice* CreateInputDevice() = 0;
private:
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/media/audio_device_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698