media: Update calls from RunAllPending() to RunUntilIdle().

media: Update calls from RunAllPending() to RunUntilIdle().

RunAllPending() is deprecated and we should all switch to RunUntilIdle() now.

BUG=131220
TEST=media_unittests, content_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167602

[xhwang, 2012-11-13 21:29:37]

PTAL!

[scherkus (not reviewing), 2012-11-13 22:00:27]

LGTM

do we need to tackle other */media/ folders?

[xhwang, 2012-11-13 22:42:05]

On 2012/11/13 22:00:27, scherkus wrote:
> LGTM
> 
> do we need to tackle other */media/ folders?

I checked content/renderer/media already. Do we have other */media folders?

[scherkus (not reviewing), 2012-11-13 23:07:22]

On 2012/11/13 22:42:05, xhwang wrote:
> On 2012/11/13 22:00:27, scherkus wrote:
> > LGTM
> > 
> > do we need to tackle other */media/ folders?
> 
> I checked content/renderer/media already. Do we have other */media folders?

grepping around it looks like we have at least the following:

chrome/browser/resources/media_internals
chrome/browser/media
chrome/browser/ui/webui/media
chrome/test/functional/media
content/renderer/media
content/browser/renderer_host/media
content/common/media
content/common/gpu/media
webkit/media

[xhwang, 2012-11-13 23:24:25]

On 2012/11/13 23:07:22, scherkus wrote:
> On 2012/11/13 22:42:05, xhwang wrote:
> > On 2012/11/13 22:00:27, scherkus wrote:
> > > LGTM
> > > 
> > > do we need to tackle other */media/ folders?
> > 
> > I checked content/renderer/media already. Do we have other */media folders?
> 
> grepping around it looks like we have at least the following:
> 
> chrome/browser/resources/media_internals
> chrome/browser/media
> chrome/browser/ui/webui/media
> chrome/test/functional/media
> content/renderer/media
> content/browser/renderer_host/media
> content/common/media
> content/common/gpu/media
> webkit/media

Thanks for the list. Check all of them and we are okay.

[commit-bot: I haz the power, 2012-11-13 23:26:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/11359193/1

[commit-bot: I haz the power, 2012-11-13 23:26:47]

Failed to apply patch for media/filters/ffmpeg_demuxer_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file media/filters/ffmpeg_demuxer_unittest.cc
  Hunk #2 succeeded at 88 (offset -4 lines).
  Hunk #3 succeeded at 149 (offset -4 lines).
  Hunk #4 succeeded at 180 (offset -4 lines).
  Hunk #5 succeeded at 190 with fuzz 1 (offset -4 lines).
  Hunk #6 succeeded at 198 (offset -4 lines).
  Hunk #7 succeeded at 206 (offset -4 lines).
  Hunk #8 succeeded at 289 (offset -4 lines).
  Hunk #9 succeeded at 305 (offset -4 lines).
  Hunk #10 succeeded at 324 (offset -4 lines).
  Hunk #11 succeeded at 366 (offset -4 lines).
  Hunk #12 succeeded at 440 (offset -4 lines).
  Hunk #13 succeeded at 462 (offset -4 lines).
  Hunk #14 succeeded at 484 (offset -4 lines).
  Hunk #15 succeeded at 500 (offset -4 lines).
  Hunk #16 succeeded at 516 (offset -4 lines).
  Hunk #17 FAILED at 567.
  Hunk #18 succeeded at 541 (offset -84 lines).
  1 out of 18 hunks FAILED -- saving rejects to file
media/filters/ffmpeg_demuxer_unittest.cc.rej

Patch:       media/filters/ffmpeg_demuxer_unittest.cc
Index: media/filters/ffmpeg_demuxer_unittest.cc
diff --git a/media/filters/ffmpeg_demuxer_unittest.cc
b/media/filters/ffmpeg_demuxer_unittest.cc
index
b86008b1b3ab3ff3e975d215a0c2897ac75f885f..e6003d04c8e9f132666f42ea163ca4cd170aa099
100644
--- a/media/filters/ffmpeg_demuxer_unittest.cc
+++ b/media/filters/ffmpeg_demuxer_unittest.cc
@@ -66,7 +66,7 @@ class FFmpegDemuxerTest : public testing::Test {
     }
 
     // Finish up any remaining tasks.
-    message_loop_.RunAllPending();
+    message_loop_.RunUntilIdle();
     // Release the reference to the demuxer.
     demuxer_ = NULL;
   }
@@ -92,7 +92,7 @@ class FFmpegDemuxerTest : public testing::Test {
   void InitializeDemuxer() {
     EXPECT_CALL(host_, SetDuration(_));
     demuxer_->Initialize(&host_, NewExpectedStatusCB(PIPELINE_OK));
-    message_loop_.RunAllPending();
+    message_loop_.RunUntilIdle();
   }
 
   MOCK_METHOD2(OnReadDoneCalled, void(int, int64));
@@ -153,7 +153,7 @@ class FFmpegDemuxerTest : public testing::Test {
     const int kMaxBuffers = 170;
     for (int i = 0; !got_eos_buffer && i < kMaxBuffers; i++) {
       audio->Read(base::Bind(&EosOnReadDone, &got_eos_buffer));
-      message_loop_.RunAllPending();
+      message_loop_.RunUntilIdle();
     }
 
     EXPECT_TRUE(got_eos_buffer);
@@ -184,7 +184,7 @@ TEST_F(FFmpegDemuxerTest, Initialize_OpenFails) {
   demuxer_->Initialize(
       &host_, NewExpectedStatusCB(DEMUXER_ERROR_COULD_NOT_OPEN));
 
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 }
 
 // TODO(acolwell): Uncomment this test when we discover a file that passes
@@ -194,7 +194,7 @@ TEST_F(FFmpegDemuxerTest, Initialize_OpenFails) {
 //  CreateDemuxer("find_stream_info_fail.webm");
 //  demuxer_->Initialize(
 //      &host_, NewExpectedStatusCB(DEMUXER_ERROR_COULD_NOT_PARSE));
-//  message_loop_.RunAllPending();
+//  message_loop_.RunUntilIdle();
 //}
 
 TEST_F(FFmpegDemuxerTest, Initialize_NoStreams) {
@@ -202,7 +202,7 @@ TEST_F(FFmpegDemuxerTest, Initialize_NoStreams) {
   CreateDemuxer("no_streams.webm");
   demuxer_->Initialize(
       &host_, NewExpectedStatusCB(DEMUXER_ERROR_NO_SUPPORTED_STREAMS));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 }
 
 TEST_F(FFmpegDemuxerTest, Initialize_NoAudioVideo) {
@@ -210,7 +210,7 @@ TEST_F(FFmpegDemuxerTest, Initialize_NoAudioVideo) {
   CreateDemuxer("no_audio_video.webm");
   demuxer_->Initialize(
       &host_, NewExpectedStatusCB(DEMUXER_ERROR_NO_SUPPORTED_STREAMS));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 }
 
 TEST_F(FFmpegDemuxerTest, Initialize_Successful) {
@@ -293,10 +293,10 @@ TEST_F(FFmpegDemuxerTest, Read_Audio) {
       demuxer_->GetStream(DemuxerStream::AUDIO);
 
   audio->Read(NewReadCB(FROM_HERE, 29, 0));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   audio->Read(NewReadCB(FROM_HERE, 27, 3000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 }
 
 TEST_F(FFmpegDemuxerTest, Read_Video) {
@@ -309,10 +309,10 @@ TEST_F(FFmpegDemuxerTest, Read_Video) {
       demuxer_->GetStream(DemuxerStream::VIDEO);
 
   video->Read(NewReadCB(FROM_HERE, 22084, 0));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   video->Read(NewReadCB(FROM_HERE, 1057, 33000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 }
 
 TEST_F(FFmpegDemuxerTest, Read_VideoNonZeroStart) {
@@ -328,11 +328,11 @@ TEST_F(FFmpegDemuxerTest, Read_VideoNonZeroStart) {
 
   // Check first buffer in video stream.
   video->Read(NewReadCB(FROM_HERE, 5636, 400000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Check first buffer in audio stream.
   audio->Read(NewReadCB(FROM_HERE, 165, 396000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Verify that the start time is equal to the lowest timestamp (ie the
audio).
   EXPECT_EQ(demuxer_->GetStartTime().InMicroseconds(), 396000);
@@ -370,28 +370,28 @@ TEST_F(FFmpegDemuxerTest, Seek) {
 
   // Read a video packet and release it.
   video->Read(NewReadCB(FROM_HERE, 22084, 0));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Issue a simple forward seek, which should discard queued packets.
   demuxer_->Seek(base::TimeDelta::FromMicroseconds(1000000),
                  NewExpectedStatusCB(PIPELINE_OK));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Audio read #1.
   audio->Read(NewReadCB(FROM_HERE, 145, 803000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Audio read #2.
   audio->Read(NewReadCB(FROM_HERE, 148, 826000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Video read #1.
   video->Read(NewReadCB(FROM_HERE, 5425, 801000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Video read #2.
   video->Read(NewReadCB(FROM_HERE, 1906, 834000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 }
 
 // A mocked callback specialization for calling Read().  Since RunWithParams()
@@ -444,7 +444,7 @@ TEST_F(FFmpegDemuxerTest, Stop) {
   // Attempt the read...
   audio->Read(base::Bind(&MockReadCB::Run, callback));
 
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // ...and verify that |callback| was deleted.
   CheckPoint(1);
@@ -466,7 +466,7 @@ TEST_F(FFmpegDemuxerTest,
StreamReadAfterStopAndDemuxerDestruction) {
   demuxer_->Stop(NewExpectedClosure());
 
   // Finish up any remaining tasks.
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Expect all calls in sequence.
   InSequence s;
@@ -488,7 +488,7 @@ TEST_F(FFmpegDemuxerTest,
StreamReadAfterStopAndDemuxerDestruction) {
   // Attempt the read...
   audio->Read(base::Bind(&MockReadCB::Run, callback));
 
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // ...and verify that |callback| was deleted.
   CheckPoint(1);
@@ -504,7 +504,7 @@ TEST_F(FFmpegDemuxerTest, DisableAudioStream) {
 
   // Submit a "disable audio stream" message to the demuxer.
   demuxer_->OnAudioRendererDisabled();
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Get our streams.
   scoped_refptr<DemuxerStream> video =
@@ -520,7 +520,7 @@ TEST_F(FFmpegDemuxerTest, DisableAudioStream) {
 
   // Attempt a read from the video stream: it should return valid data.
   video->Read(NewReadCB(FROM_HERE, 22084, 0));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Attempt a read from the audio stream: it should immediately return end of
   // stream without requiring the message loop to read data.
@@ -567,7 +567,7 @@ TEST_F(FFmpegDemuxerTest, ProtocolRead) {
   EXPECT_EQ(size, position);
 
   demuxer_->Stop(NewExpectedClosure());
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 }
 
 TEST_F(FFmpegDemuxerTest, ProtocolGetSetPosition) {
@@ -625,28 +625,28 @@ TEST_F(FFmpegDemuxerTest, SeekWithCuesBeforeFirstCluster)
{
 
   // Read a video packet and release it.
   video->Read(NewReadCB(FROM_HERE, 22084, 0));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Issue a simple forward seek, which should discard queued packets.
   demuxer_->Seek(base::TimeDelta::FromMicroseconds(2500000),
                  NewExpectedStatusCB(PIPELINE_OK));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Audio read #1.
   audio->Read(NewReadCB(FROM_HERE, 40, 2403000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Audio read #2.
   audio->Read(NewReadCB(FROM_HERE, 42, 2406000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Video read #1.
   video->Read(NewReadCB(FROM_HERE, 5276, 2402000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 
   // Video read #2.
   video->Read(NewReadCB(FROM_HERE, 1740, 2436000));
-  message_loop_.RunAllPending();
+  message_loop_.RunUntilIdle();
 }
 
 // Ensure ID3v1 tag reading is disabled.  id3_test.mp3 has an ID3v1 tag with
the

[commit-bot: I haz the power, 2012-11-14 01:55:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/11359193/9002

[commit-bot: I haz the power, 2012-11-14 02:18:45]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-14 02:18:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/11359193/9003

[commit-bot: I haz the power, 2012-11-14 05:08:33]

Change committed as 167602