ui/views/controls/table/table_view_views.cc - Issue 11359172: ui: Remove implicit flooring in skia rect conversion methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/table/table_view_views.cc

Issue 11359172: ui: Remove implicit flooring in skia rect conversion methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make root window transform in tests produce an integer result Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/table/table_view_views.cc

diff --git a/ui/views/controls/table/table_view_views.cc b/ui/views/controls/table/table_view_views.cc

index bb531132841a4dac34975ad2d6cfa496dded7423..b9139b80c7a9d6c313e0d05ca821338bfb4c1f21 100644

--- a/ui/views/controls/table/table_view_views.cc

+++ b/ui/views/controls/table/table_view_views.cc

@@ -9,6 +9,7 @@

#include "ui/base/models/table_model.h"

#include "ui/gfx/canvas.h"

#include "ui/gfx/image/image_skia.h"

+#include "ui/gfx/rect_conversions.h"

#include "ui/gfx/skia_util.h"

#include "ui/views/controls/scroll_view.h"

#include "ui/views/controls/table/table_view_observer.h"

@@ -220,7 +221,9 @@ void TableView::OnPaint(gfx::Canvas* canvas) {

{

SkRect sk_clip_rect;

if (canvas->sk_canvas()->getClipBounds(&sk_clip_rect)) {

- gfx::Rect clip_rect = gfx::SkRectToRect(sk_clip_rect);

+ // Pixels partially inside the clip rect should be included.

+ gfx::Rect clip_rect = gfx::ToEnclosingRect(

+ gfx::SkRectToRectF(sk_clip_rect));

min_y = clip_rect.y();

max_y = clip_rect.bottom();

} else {

« no previous file with comments | « ui/gfx/transform.cc ('k') | ui/views/controls/tree/tree_view_views.cc » ('j') | no next file with comments »