Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: chrome/browser/extensions/app_host/app_host.rc

Issue 11359133: Add default icon to app_host.exe, and use it in shortcuts during installation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Small comment change. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_host/app_host.rc
diff --git a/chrome/browser/extensions/app_host/app_host.rc b/chrome/browser/extensions/app_host/app_host.rc
index ffd5341a22e1a90bac562d7967c0a89fe017b83b..572e66e7cdc1fb38ffce21115da49de2c3434ca2 100644
--- a/chrome/browser/extensions/app_host/app_host.rc
+++ b/chrome/browser/extensions/app_host/app_host.rc
@@ -1,5 +1,6 @@
// Microsoft Visual C++ generated resource script.
//
+#include "app_host_resource.h"
#define APSTUDIO_READONLY_SYMBOLS
/////////////////////////////////////////////////////////////////////////////
@@ -24,6 +25,21 @@ LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
/////////////////////////////////////////////////////////////////////////////
//
+// Icon
+//
+
+// The application icon should: have the lowest ID, be placed first, and its
+// resource name should be alphabetically less than the name of any other icon
+// resource (http://msdn.microsoft.com/en-us/library/ms997538.aspx).
+// Note: chrome/installer/util/shell_util.cc depends on the order and number of
erikwright (departed) 2012/11/15 16:35:12 Is this 'Note: ...' relevant to app_host or only t
huangs 2012/11/15 16:51:39 Following mini_installer.rc's lead, and simplifyin
+// icons. To avoid breaking existing shortcuts, add new icons at the end
+// (following the ordering described above).
+
+// Icon for the App Lancher.
+IDR_APP_HOST_MAIN ICON "..\\..\\..\\app\\theme\\app_list.ico"
+
+/////////////////////////////////////////////////////////////////////////////
+//
// GOOGLEUPDATEAPPLICATIONCOMMANDS is a "well-known" marker resource defined
// by Omaha. Executables must both be signed by Google and contain the marker
// in order to expose application commands.
« no previous file with comments | « no previous file | chrome/browser/extensions/app_host/app_host_resource.h » ('j') | chrome/installer/setup/install_worker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698