Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: chrome/installer/util/shell_util.h

Issue 11359133: Add default icon to app_host.exe, and use it in shortcuts during installation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Comment fixes to .rc file, and prefixing icon id with IDI_. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index b521527f9f3e6020bf76d3b704e01fea0e90cad8..e8f7570635edbe2ce7ea351797d44c1e3295ad7a 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -312,12 +312,10 @@ class ShellUtil {
const ShellUtil::ShortcutProperties& properties,
ShellUtil::ShortcutOperation operation);
- // This method appends the Chrome icon index inside chrome.exe to the
- // chrome.exe path passed in as input, to generate the full path for
- // Chrome icon that can be used as value for Windows registry keys.
- // |chrome_exe| full path to chrome.exe.
- static string16 GetChromeIcon(BrowserDistribution* dist,
- const string16& chrome_exe);
+ // Combines |icon_path| with |icon_index| into a string that can be
grt (UTC plus 2) 2012/11/16 05:05:03 // Returns the string "|icon_path|,|icon_index|" (
huangs 2012/11/16 17:08:17 Done.
+ // used as value for Windows registry keys.
+ static string16 GetIconString(const string16& icon_path,
grt (UTC plus 2) 2012/11/16 05:05:03 GetIconString -> FormatIconLocation for consistenc
huangs 2012/11/16 17:08:17 Done.
+ int icon_index);
grt (UTC plus 2) 2012/11/16 05:05:03 move to previous line
huangs 2012/11/16 17:08:17 Done.
// This method returns the command to open URLs/files using chrome. Typically
// this command is written to the registry under shell\open\command key.

Powered by Google App Engine
This is Rietveld 408576698