Chromium Code Reviews| Index: chrome/installer/util/shell_util.h |
| diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h |
| index b521527f9f3e6020bf76d3b704e01fea0e90cad8..e8f7570635edbe2ce7ea351797d44c1e3295ad7a 100644 |
| --- a/chrome/installer/util/shell_util.h |
| +++ b/chrome/installer/util/shell_util.h |
| @@ -312,12 +312,10 @@ class ShellUtil { |
| const ShellUtil::ShortcutProperties& properties, |
| ShellUtil::ShortcutOperation operation); |
| - // This method appends the Chrome icon index inside chrome.exe to the |
| - // chrome.exe path passed in as input, to generate the full path for |
| - // Chrome icon that can be used as value for Windows registry keys. |
| - // |chrome_exe| full path to chrome.exe. |
| - static string16 GetChromeIcon(BrowserDistribution* dist, |
| - const string16& chrome_exe); |
| + // Combines |icon_path| with |icon_index| into a string that can be |
|
grt (UTC plus 2)
2012/11/16 05:05:03
// Returns the string "|icon_path|,|icon_index|" (
huangs
2012/11/16 17:08:17
Done.
|
| + // used as value for Windows registry keys. |
| + static string16 GetIconString(const string16& icon_path, |
|
grt (UTC plus 2)
2012/11/16 05:05:03
GetIconString -> FormatIconLocation for consistenc
huangs
2012/11/16 17:08:17
Done.
|
| + int icon_index); |
|
grt (UTC plus 2)
2012/11/16 05:05:03
move to previous line
huangs
2012/11/16 17:08:17
Done.
|
| // This method returns the command to open URLs/files using chrome. Typically |
| // this command is written to the registry under shell\open\command key. |