Issue 11359130: Make formatting error message side-effect-free.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11359130: Make formatting error message side-effect-free. (Closed)

Created:
8 years, 1 month ago by Yang

Modified:
8 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make formatting error message side-effect-free. BUG=v8:2398 Committed: https://code.google.com/p/v8/source/detail?r=12926

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -5 lines)			Patch
M	src/isolate.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/messages.js	View	2 chunks	+21 lines, -1 line	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+21 lines, -0 lines	2 comments	Download
A +	test/mjsunit/regress/regress-2398.js	View	1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years, 1 month ago (2012-11-12 10:14:00 UTC) #2

LGTM with nits.

http://codereview.chromium.org/11359130/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/11359130/diff/1/src/runtime.cc#newcode4248
src/runtime.cc:4248: if (!lookup.IsProperty()) return
isolate->heap()->undefined_value();
With the change below, this can change to ...!lookup.IsFound()...

http://codereview.chromium.org/11359130/diff/1/src/runtime.cc#newcode4256
src/runtime.cc:4256: default:
Please explicitly list all PropertyTypes. We should never use a default case for
enums, because it makes it impossible to find the places which should change
when the corresponding enum changes in an automatic way.

Expand Messages | Collapse Messages