Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 11359117: [Mac] Temporarily stop clearing zombie objects. (Closed)

Created:
8 years, 1 month ago by Scott Hess - ex-Googler
Modified:
8 years, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Mac] Temporarily stop clearing zombie objects. Zombie objects are cleared to '!' to force faster failure. The bug involves a containing object being zombied, and then trying to message something it owns. This change will provide info on the object being messaged, and perhaps info on who deallocated it. BUG=154483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/common/mac/objc_zombie.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Hess - ex-Googler
I suspect that this case won't be an autorelease-pool case, because I'm betting it's happening ...
8 years, 1 month ago (2012-11-08 22:17:38 UTC) #1
Robert Sesek
LGTM On 2012/11/08 22:17:38, shess wrote: > I suspect that this case won't be an ...
8 years, 1 month ago (2012-11-09 00:08:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11359117/1
8 years, 1 month ago (2012-11-09 22:11:57 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-10 00:45:07 UTC) #4
Change committed as 167021

Powered by Google App Engine
This is Rietveld 408576698