Consolidate polymorphic calls due to elements transitions.

Consolidate polymorphic calls due to elements transitions.

Committed: https://code.google.com/p/v8/source/detail?r=12960

[Toon Verwaest, 2012-11-08 13:47:06]

PTAL

[danno, 2012-11-13 22:52:32]

LGTM with nit

http://codereview.chromium.org/11359104/diff/6001/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/11359104/diff/6001/src/hydrogen.cc#newcode7515
src/hydrogen.cc:7515: // Checks if all maps in |types| are from the same family,
ie, are elements
nit: i.e.

http://codereview.chromium.org/11359104/diff/6001/src/hydrogen.cc#newcode7519
src/hydrogen.cc:7519: static Map* CheckSameElementsFamily(SmallMapList* types) {
Maybe this should be a static method on Map? I know that Michael might want to
reuse some of this functionality?

http://codereview.chromium.org/11359104/diff/6001/src/hydrogen.cc#newcode7607
src/hydrogen.cc:7607: if (!monomorphic) {
since you handle both cases, why not make it "if (monomorphic)" with the
positive case first?

[Toon Verwaest, 2012-11-14 11:57:38]

Addressed comments.

https://chromiumcodereview.appspot.com/11359104/diff/6001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/11359104/diff/6001/src/hydrogen.cc#new...
src/hydrogen.cc:7515: // Checks if all maps in |types| are from the same family,
ie, are elements
On 2012/11/13 22:52:32, danno wrote:
> nit: i.e.

Done.

https://chromiumcodereview.appspot.com/11359104/diff/6001/src/hydrogen.cc#new...
src/hydrogen.cc:7519: static Map* CheckSameElementsFamily(SmallMapList* types) {
For now I'd keep it here. I doubt that he can reuse it after discussing with him
last week. This code is really optimized to check if a set of maps all belong to
the same family, he rather will have to check if a single maps belongs to the
family of another single map.

On 2012/11/13 22:52:32, danno wrote:
> Maybe this should be a static method on Map? I know that Michael might want to
> reuse some of this functionality?

https://chromiumcodereview.appspot.com/11359104/diff/6001/src/hydrogen.cc#new...
src/hydrogen.cc:7607: if (!monomorphic) {
On 2012/11/13 22:52:32, danno wrote:
> since you handle both cases, why not make it "if (monomorphic)" with the
> positive case first? 

Done.