Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: chrome/browser/extensions/event_router.h

Issue 11359081: Lazy initialization for ProcessesEventRouter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixor Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/event_router.h
diff --git a/chrome/browser/extensions/event_router.h b/chrome/browser/extensions/event_router.h
index cbfb1b80abaa432e118121b2660ffba3b6f55416..94f81da8189cd903f95b1b6e4cccb5be8f6fac89 100644
--- a/chrome/browser/extensions/event_router.h
+++ b/chrome/browser/extensions/event_router.h
@@ -22,7 +22,6 @@
#include "ipc/ipc_sender.h"
class GURL;
-class ExtensionDevToolsManager;
class Profile;
namespace content {
@@ -47,6 +46,16 @@ class EventRouter : public content::NotificationObserver,
USER_GESTURE_NOT_ENABLED = 2,
};
+ // Observers register interest in events with a particular name and are
+ // notified when a listener is added or removed for that |event_name|.
+ class Observer {
+ public:
+ // Called when a listener is added.
+ virtual void OnListenerAdded(const std::string& event_name) {}
+ // Called when a listener is removed.
+ virtual void OnListenerRemoved(const std::string& event_name) {}
+ };
+
// Sends an event via ipc_sender to the given extension. Can be called on any
// thread.
static void DispatchEvent(IPC::Sender* ipc_sender,
@@ -73,6 +82,15 @@ class EventRouter : public content::NotificationObserver,
EventListenerMap& listeners() { return listeners_; }
+ // Registers an observer to be notified when an event listener for
+ // |event_name| is added or removed. There can currently be only one observer
+ // for each distinct |event_name|.
+ void RegisterObserver(Observer* observer,
+ const std::string& event_name);
+
+ // Unregisters an observer from all events.
+ void UnregisterObserver(Observer* observer);
+
// Add or remove the extension as having a lazy background page that listens
// to the event. The difference from the above methods is that these will be
// remembered even after the process goes away. We use this list to decide
@@ -249,10 +267,11 @@ class EventRouter : public content::NotificationObserver,
content::NotificationRegistrar registrar_;
- scoped_refptr<ExtensionDevToolsManager> extension_devtools_manager_;
-
EventListenerMap listeners_;
+ typedef std::map<std::string, Observer*> ObserverMap;
+ ObserverMap observers_;
+
// True if we should dispatch the event signalling that Chrome was updated
// upon loading an extension.
bool dispatch_chrome_updated_event_;

Powered by Google App Engine
This is Rietveld 408576698