ui: Add methods to Rect classes to get points at each of the rect's corners.

ui: Add methods to Rect classes to get points at each of the rect's corners.

This adds the following methods:
RectBase::TopRight()
RectBase::BottomLeft()
RectBase::BottomRight()

RectBase::origin() still provides the rect's top-left corner.

Tests:
ui_unittests:RectTest.Cornders

BUG=147395
R=sky


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168859

[danakj, 2012-11-14 20:02:26]

+enne for cc/

[sky, 2012-11-14 22:23:43]

https://codereview.chromium.org/11358240/diff/1/ui/gfx/rect_base.h
File ui/gfx/rect_base.h (right):

https://codereview.chromium.org/11358240/diff/1/ui/gfx/rect_base.h#newcode50
ui/gfx/rect_base.h:50: PointClass TopLeft() const { return PointClass(x(), y());
}
This is the same as origin(), do we really need it?

https://codereview.chromium.org/11358240/diff/1/ui/gfx/rect_base.h#newcode51
ui/gfx/rect_base.h:51: PointClass TopRight() const { return PointClass(right(),
y()); }
Can these be named unix_hacker style?

[danakj, 2012-11-14 22:36:34]

https://codereview.chromium.org/11358240/diff/1/ui/gfx/rect_base.h
File ui/gfx/rect_base.h (right):

https://codereview.chromium.org/11358240/diff/1/ui/gfx/rect_base.h#newcode50
ui/gfx/rect_base.h:50: PointClass TopLeft() const { return PointClass(x(), y());
}
On 2012/11/14 22:23:43, sky wrote:
> This is the same as origin(), do we really need it?

It's true, we don't. I liked having consistency so you could for instance
BottomRight() - TopLeft(), and use the same vocabulary throughout.

I can remove it if you like though.

https://codereview.chromium.org/11358240/diff/1/ui/gfx/rect_base.h#newcode51
ui/gfx/rect_base.h:51: PointClass TopRight() const { return PointClass(right(),
y()); }
On 2012/11/14 22:23:43, sky wrote:
> Can these be named unix_hacker style?

Done.

[sky, 2012-11-14 23:24:59]

On Wed, Nov 14, 2012 at 2:36 PM,  <danakj@chromium.org> wrote:
>
> https://codereview.chromium.org/11358240/diff/1/ui/gfx/rect_base.h
> File ui/gfx/rect_base.h (right):
>
> https://codereview.chromium.org/11358240/diff/1/ui/gfx/rect_base.h#newcode50
> ui/gfx/rect_base.h:50: PointClass TopLeft() const { return
> PointClass(x(), y()); }
> On 2012/11/14 22:23:43, sky wrote:
>>
>> This is the same as origin(), do we really need it?
>
>
> It's true, we don't. I liked having consistency so you could for
> instance BottomRight() - TopLeft(), and use the same vocabulary
> throughout.
>
> I can remove it if you like though.

Yes please. Especially since origin() can be const& where as the others can't.
>
> https://codereview.chromium.org/11358240/diff/1/ui/gfx/rect_base.h#newcode51
> ui/gfx/rect_base.h:51: PointClass TopRight() const { return
> PointClass(right(), y()); }
> On 2012/11/14 22:23:43, sky wrote:
>>
>> Can these be named unix_hacker style?
>
>
> Done.
>
> https://codereview.chromium.org/11358240/

[commit-bot: I haz the power, 2012-11-20 05:14:25]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[danakj, 2012-11-20 05:15:01]

Oh, woops. PTAL.

I've removed the top_left() in preference for origin().

[enne (OOO), 2012-11-20 05:28:00]

cc lgtm

[sky, 2012-11-20 16:39:45]

LGTM

[commit-bot: I haz the power, 2012-11-20 16:43:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11358240/12001

[commit-bot: I haz the power, 2012-11-20 20:28:08]

Change committed as 168859