Add simple WebSocket server implementation.

remoting/host/websocket_listener.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_WEBSOCKET_LISTENER_H_
+#define REMOTING_HOST_WEBSOCKET_LISTENER_H_
+
+#include <set>
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
+#include "net/socket/tcp_server_socket.h"
+
+namespace net {
+class IPEndPoint;
+class StreamSocket;
+}  // namespace net
+
+namespace remoting {
+
+class WebsocketConnection;
+
+class WebsocketListener {
+ public:
+  typedef base::Callback<
+      void(scoped_ptr<WebsocketConnection> connection)> NewConnectionCallback;
+
+  WebsocketListener();
+  ~WebsocketListener();
+
+  // Start listening on the specified port. Returns false in case of a failure.

[Wez, 2012/11/15 02:28:37]

Why not return a net/ error, or provide a result code in the
NewConnectionCallback and make this asynchronous?

[Wez, 2012/11/15 02:28:37]

nit: Clarify the tear-down semantics; is |callback| guaranteed never to be
called after WebsocketListener is destroyed?

[Wez, 2012/11/15 02:28:37]

nit: port -> address, Start -> Starts

[Sergey Ulanov, 2012/11/15 21:01:03]

Done.

[Sergey Ulanov, 2012/11/15 21:01:03]

Done.

[Sergey Ulanov, 2012/11/15 21:01:03]

Done.

+  bool Listen(const net::IPEndPoint& address,

[Wez, 2012/11/15 02:28:37]

nit: If you make |address| an in-out parameter, it can be used both to specify
the requested port, and the one that actually got allocated, if the caller
passes in zero?

[Sergey Ulanov, 2012/11/15 21:01:03]

I don't think that using in-out parameter here is the right thing to do. We can
add GetLocalAddress() to match net::ServerSocket interface, when it becomes
necessary.

+              const NewConnectionCallback& callback);
+
+ private:
+  void DoAccept();
+  void OnAccepted(int result);
+  void HandleAcceptResult(int result);
+  void OnConnected(WebsocketConnection* connection_ptr, bool handshake_result);

[Wez, 2012/11/15 02:28:37]

Each of these methods need a (short) comment explaining its purpose.

[Sergey Ulanov, 2012/11/15 21:01:03]

Done.

+
+  scoped_ptr<net::TCPServerSocket> tcp_socket_;
+  NewConnectionCallback new_connection_callback_;
+  scoped_ptr<net::StreamSocket> accepted_socket_;
+  std::set<WebsocketConnection*> pending_connections_;
+
+  base::WeakPtrFactory<WebsocketListener> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(WebsocketListener);
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_WEBSOCKET_LISTENER_H_