Enforce 15 minutes timeout for all operations and 30 minutes for checkouts.

Enforce 15 minutes timeout for all operations and 30 minutes for checkouts.

svn commit likes to hang indefinitely whenever the svnserve server forgets
about the client. This changes ensures the commit queue won't be blocked by
this problem.

Add --quiet to the git fetch command but do not capture anymore.


R=petermayo@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166725

[Peter Mayo, 2012-11-08 19:04:59]

LGTM + nit

15 minutes sometimes not enough for update?  Didn't expect that, but that's in
the constants.  The code looks good.

https://codereview.chromium.org/11358165/diff/1/checkout.py
File checkout.py (right):

https://codereview.chromium.org/11358165/diff/1/checkout.py#newcode502
checkout.py:502: timeout=FETCH_TIMEOUT)
I would think checkout and update may be different enough in practice to warrant
separate timeouts.  But if 30 minutes is enough for either, the point is moot.

https://codereview.chromium.org/11358165/diff/1/checkout.py#newcode720
checkout.py:720: ['fetch', self.remote, self.remote_branch, '--quiet'],
Add quiet to CL description.

[M-A Ruel, 2012-11-08 19:07:57]

https://codereview.chromium.org/11358165/diff/1/checkout.py
File checkout.py (right):

https://codereview.chromium.org/11358165/diff/1/checkout.py#newcode502
checkout.py:502: timeout=FETCH_TIMEOUT)
On 2012/11/08 19:04:59, Peter Mayo wrote:
> I would think checkout and update may be different enough in practice to
warrant
> separate timeouts.  But if 30 minutes is enough for either, the point is moot.

I think it's fine. I'll change otherwise but I'm confident it's well enough.

[commit-bot: I haz the power, 2012-11-08 19:08:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/11358165/1

[commit-bot: I haz the power, 2012-11-08 19:10:51]

Change committed as 166725