[net] Set default HostCache size according to HostCacheSize field trial.

[net] Set default HostCache size according to HostCacheSize field trial.

BUG=114277, 143454
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166472

[szym, 2012-11-06 21:53:24]

The HostCacheSize field trial is going to be defined in finch. It's not there
yet, but the group name will be "100A", "100B", "500A", "500B", etc. similar to
CacheSensitivityAnalysis field trial configured in
http://src.chromium.org/chrome/trunk/src/chrome/browser/chrome_browser_field_...
and used in
http://src.chromium.org/chrome/trunk/src/net/http/http_cache_transaction.cc

[mmenke, 2012-11-07 16:11:00]

LGTM

https://codereview.chromium.org/11358125/diff/1/net/base/host_cache.cc
File net/base/host_cache.cc (right):

https://codereview.chromium.org/11358125/diff/1/net/base/host_cache.cc#newcode94
net/base/host_cache.cc:94: &max_entries) || max_entries > kSaneMaxEntries) {
How are we going to handle recording histograms on ChromeOS?  Not set the
HostCacheSize via Finch, not set it Chrome side, not record HostCacheSize field
trial stats on ChromeOS, just just know enough to ignore them on ChromeOS?

If we're just not going to set it via Finch, then we may want to have this code
run on ChromeOS as well (And default to 1000 entries instead of 100).

[szym, 2012-11-07 16:22:42]

https://codereview.chromium.org/11358125/diff/1/net/base/host_cache.cc
File net/base/host_cache.cc (right):

https://codereview.chromium.org/11358125/diff/1/net/base/host_cache.cc#newcode94
net/base/host_cache.cc:94: &max_entries) || max_entries > kSaneMaxEntries) {
On 2012/11/07 16:11:00, Matt Menke wrote:
> How are we going to handle recording histograms on ChromeOS?  Not set the
> HostCacheSize via Finch, not set it Chrome side, not record HostCacheSize
field
> trial stats on ChromeOS, just just know enough to ignore them on ChromeOS?
> 
> If we're just not going to set it via Finch, then we may want to have this
code
> run on ChromeOS as well (And default to 1000 entries instead of 100).

My bad, I forgot to remove the #ifdef. There's no need for breakout on CrOS.
Fixed.

[mmenke, 2012-11-07 16:24:23]

On 2012/11/07 16:22:42, szym wrote:
> https://codereview.chromium.org/11358125/diff/1/net/base/host_cache.cc
> File net/base/host_cache.cc (right):
> 
>
https://codereview.chromium.org/11358125/diff/1/net/base/host_cache.cc#newcode94
> net/base/host_cache.cc:94: &max_entries) || max_entries > kSaneMaxEntries) {
> On 2012/11/07 16:11:00, Matt Menke wrote:
> > How are we going to handle recording histograms on ChromeOS?  Not set the
> > HostCacheSize via Finch, not set it Chrome side, not record HostCacheSize
> field
> > trial stats on ChromeOS, just just know enough to ignore them on ChromeOS?
> > 
> > If we're just not going to set it via Finch, then we may want to have this
> code
> > run on ChromeOS as well (And default to 1000 entries instead of 100).
> 
> My bad, I forgot to remove the #ifdef. There's no need for breakout on CrOS.
> Fixed.

LGTM

[commit-bot: I haz the power, 2012-11-07 16:28:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szym@chromium.org/11358125/1003

[commit-bot: I haz the power, 2012-11-07 18:24:04]

Change committed as 166472