Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 11358080: Separate TransferableResource into own header (Closed)

Created:
8 years, 1 month ago by piman
Modified:
8 years, 1 month ago
Reviewers:
danakj, jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Separate TransferableResource into own header This is so that we can write the picklers without having to include webcore/wtf. This also changes the resource transfer functions to avoid copies. BUG=146080 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165847

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : remove unused accessor #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -62 lines) Patch
M cc/DEPS View 1 1 chunk +3 lines, -0 lines 1 comment Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resource_provider.h View 1 2 3 chunks +4 lines, -20 lines 0 comments Download
M cc/resource_provider.cc View 7 chunks +21 lines, -30 lines 0 comments Download
M cc/resource_provider_unittest.cc View 6 chunks +18 lines, -12 lines 0 comments Download
A cc/transferable_resource.h View 1 chunk +44 lines, -0 lines 0 comments Download
A cc/transferable_resource.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
piman
Dana: please review James: please take a look at DEPS. This header will be included ...
8 years, 1 month ago (2012-11-03 00:54:48 UTC) #1
danakj
https://codereview.chromium.org/11358080/diff/1/cc/resource_provider.h File cc/resource_provider.h (right): https://codereview.chromium.org/11358080/diff/1/cc/resource_provider.h#newcode52 cc/resource_provider.h:52: GraphicsContext* context() const { return m_context; } Why'd you ...
8 years, 1 month ago (2012-11-03 01:00:51 UTC) #2
piman
On 2012/11/03 01:00:51, danakj wrote: > https://codereview.chromium.org/11358080/diff/1/cc/resource_provider.h > File cc/resource_provider.h (right): > > https://codereview.chromium.org/11358080/diff/1/cc/resource_provider.h#newcode52 > ...
8 years, 1 month ago (2012-11-03 01:02:32 UTC) #3
danakj
k, lgtm without that :)
8 years, 1 month ago (2012-11-03 01:03:40 UTC) #4
piman
https://codereview.chromium.org/11358080/diff/1/cc/resource_provider.h File cc/resource_provider.h (right): https://codereview.chromium.org/11358080/diff/1/cc/resource_provider.h#newcode52 cc/resource_provider.h:52: GraphicsContext* context() const { return m_context; } On 2012/11/03 ...
8 years, 1 month ago (2012-11-03 01:05:47 UTC) #5
jamesr
lgtm https://codereview.chromium.org/11358080/diff/4002/cc/DEPS File cc/DEPS (right): https://codereview.chromium.org/11358080/diff/4002/cc/DEPS#newcode34 cc/DEPS:34: "+third_party/WebKit/Source/Platform/chromium/public/WebCompositorTransferableResourceList.h" lgtm
8 years, 1 month ago (2012-11-03 01:23:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/11358080/4002
8 years, 1 month ago (2012-11-03 01:30:53 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-03 07:10:23 UTC) #8
Change committed as 165847

Powered by Google App Engine
This is Rietveld 408576698