Issue 11358065: Improve handle allocation in JSON.parse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11358065: Improve handle allocation in JSON.parse. (Closed)

Created:
8 years, 1 month ago by Yang

Modified:
8 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve handle allocation in JSON.parse. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12850

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/json-parser.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

8 years, 1 month ago (2012-11-05 10:14:47 UTC) #2

lgtm with nit

https://chromiumcodereview.appspot.com/11358065/diff/1/src/json-parser.h
File src/json-parser.h (right):

https://chromiumcodereview.appspot.com/11358065/diff/1/src/json-parser.h#newc...
src/json-parser.h:614: return isolate()->factory()->empty_string();
You can directly use factory() without isolate()->

Expand Messages | Collapse Messages