Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 11358028: login_utils_browsertest.cc is flaky. (Closed)

Created:
8 years, 1 month ago by achuithb
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

login_utils_browsertest.cc is flaky. BUG=158839 TEST=tests pass. TBR=nkostylev@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/11358028/1
8 years, 1 month ago (2012-10-31 23:54:20 UTC) #1
achuithb
8 years, 1 month ago (2012-11-01 00:00:02 UTC) #2
commit-bot: I haz the power
List of reviewers changed. joaodasilva@chromium.org,nkostylev@chromium.org did a drive-by without LGTM'ing!
8 years, 1 month ago (2012-11-01 04:32:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/11358028/1
8 years, 1 month ago (2012-11-01 04:51:27 UTC) #4
commit-bot: I haz the power
Change committed as 165294
8 years, 1 month ago (2012-11-01 04:51:36 UTC) #5
Nikita (slow)
lgtm but I think you should have just disabled LoginUtilsBlockingLoginTest.EnterpriseLoginBlocksForEnterpriseUser
8 years, 1 month ago (2012-11-01 18:54:45 UTC) #6
achuithb
On 2012/11/01 18:54:45, Nikita Kostylev wrote: > lgtm but I think you should have just ...
8 years, 1 month ago (2012-11-01 19:10:20 UTC) #7
achuithb
On 2012/11/01 19:10:20, achuith.bhandarkar wrote: > On 2012/11/01 18:54:45, Nikita Kostylev wrote: > > lgtm ...
8 years, 1 month ago (2012-11-01 19:11:17 UTC) #8
Nikita (slow)
8 years, 1 month ago (2012-11-01 19:22:20 UTC) #9
makes sense to disable whole test then, thanks!

lgtm

Powered by Google App Engine
This is Rietveld 408576698