Give the possibility of placing a custom annotated_steps in tools inside the package.

Give the possibility of placing a custom annotated_steps in tools inside the package.

If that exists, it will be run instead of the usual steps.

BUG=
R=ricow@google.com

Committed: https://github.com/dart-lang/package-bots/commit/28c5048fb035fe75aa8a60d8874c96f6911800a9

Reverted: https://github.com/dart-lang/package-bots/commit/637aabf7498504d6350a5c7f1d6c3193246e550d

Committed: https://github.com/dart-lang/package-bots/commit/8a5e5fb0be72c383d7486f09a96a7d953589102b

[sigurdm, 2015-05-13 09:40:28]

Patchset #1 (id:1) has been deleted

[sigurdm, 2015-05-13 09:40:47]

sigurdm@google.com changed reviewers:
+ ricow@google.com

[ricow1, 2015-05-13 10:00:45]

Why all those extra bot_info parameters, they are not used?
Additionally, if you really want to make this automatic (as in not explicit in
this script which repos you want to do this for), you should add another
possible value in
https://github.com/dart-lang/package-bots/blob/master/config_parser.py
I would suggest use_other_annotated : location_of_script

[sigurdm, 2015-05-13 13:50:35]

Patchset #2 (id:40001) has been deleted

[sigurdm, 2015-05-13 13:54:48]

They are used. The problem was that they were top-level before, so in some
places they were passed as arguments, in some places read from the top-level.
Now they only exist in main, and must be passed on everywhere.

I changed a bit in the way config_parser works. It now does not handle
replacement of "magic-markers" but that is handled before processes are run. It
makes it much more decoupled.
I also stream lined the format-checking a bit, so It can have an entry with a
different type.

[sigurdm, 2015-05-18 14:28:09]

Patchset #3 (id:80001) has been deleted

[sigurdm, 2015-05-18 14:28:21]

PTAL

[ricow1, 2015-05-19 09:58:06]

lgtm

https://chromiumcodereview.appspot.com/1135343004/diff/100001/annotated_steps.py
File annotated_steps.py (right):

https://chromiumcodereview.appspot.com/1135343004/diff/100001/annotated_steps...
annotated_steps.py:382: with BuildStep('Running custom script %s' %
custom_script, swallow_error=True):
long line

https://chromiumcodereview.appspot.com/1135343004/diff/100001/config_parser.py
File config_parser.py (right):

https://chromiumcodereview.appspot.com/1135343004/diff/100001/config_parser.p...
config_parser.py:12: (key, type(value)))
indentation

[sigurdm, 2015-05-19 13:32:17]

I changed GetVM() because it seemed to be not working. Could you confirm if the
new location should work?

https://chromiumcodereview.appspot.com/1135343004/diff/100001/annotated_steps.py
File annotated_steps.py (right):

https://chromiumcodereview.appspot.com/1135343004/diff/100001/annotated_steps...
annotated_steps.py:382: with BuildStep('Running custom script %s' %
custom_script, swallow_error=True):
On 2015/05/19 09:58:05, ricow1 wrote:
> long line

Done.

https://chromiumcodereview.appspot.com/1135343004/diff/100001/config_parser.py
File config_parser.py (right):

https://chromiumcodereview.appspot.com/1135343004/diff/100001/config_parser.p...
config_parser.py:12: (key, type(value)))
On 2015/05/19 09:58:05, ricow1 wrote:
> indentation

Done.

[ricow1, 2015-05-19 13:38:09]

lgtm

https://chromiumcodereview.appspot.com/1135343004/diff/140001/annotated_steps.py
File annotated_steps.py (right):

https://chromiumcodereview.appspot.com/1135343004/diff/140001/annotated_steps...
annotated_steps.py:217: return os.path.join(DART_DIR, 'tools/testing/bin',
bot_info.system, executable)
long line

[sigurdm, 2015-05-19 13:39:51]

https://chromiumcodereview.appspot.com/1135343004/diff/140001/annotated_steps.py
File annotated_steps.py (right):

https://chromiumcodereview.appspot.com/1135343004/diff/140001/annotated_steps...
annotated_steps.py:217: return os.path.join(DART_DIR, 'tools/testing/bin',
bot_info.system, executable)
On 2015/05/19 13:38:09, ricow1 wrote:
> long line

Done.

[sigurdm, 2015-05-19 13:41:47]

Committed patchset #6 (id:160001) manually as
28c5048fb035fe75aa8a60d8874c96f6911800a9 (presubmit successful).

[sigurdm, 2015-05-19 14:02:43]

I had a missing parameter.
TBR.

[sigurdm, 2015-05-19 14:04:06]

Committed patchset #7 (id:180001) manually as
8a5e5fb0be72c383d7486f09a96a7d953589102b (presubmit successful).