Add a class for management of thermal throttling

Add a class for management of thermal throttling

The new class allows detection of whether the device is now, or has been, thermally throttled, hence allowing rejection of performance results affected by thermal throttling.

BUG=158575
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165367

[bulach, 2012-10-31 10:44:47]

lgtm, thanks! just nits:

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
File build/android/pylib/perf_tests_helper.py (right):

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:124: class ThermalThrottle(object):
it'd make sense to have this class in its own file in this directory,
thermal_throttle.py

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:132: Currently assumes an OMap device,
but I don't know of any others with
nit: people told me in the past to avoid using first person.. probably best to
just remove the last sentence and just keep "Assumes an OMap device." ?

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:135: _throttled = False
nit: this should be a regular member in __init__ (afaict, here it's a static
member)

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:151: def _readLog(self):
nit: _ReadLog

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:153: log =
self._adb.RunShellCommand("dmesg -c")
nit: single quotes on all strings here.

[Anthony Berent, 2012-10-31 15:14:02]

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
File build/android/pylib/perf_tests_helper.py (right):

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:124: class ThermalThrottle(object):
On 2012/10/31 10:44:47, bulach wrote:
> it'd make sense to have this class in its own file in this directory,
> thermal_throttle.py

Done.

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:132: Currently assumes an OMap device,
but I don't know of any others with
On 2012/10/31 10:44:47, bulach wrote:
> nit: people told me in the past to avoid using first person.. probably best to
> just remove the last sentence and just keep "Assumes an OMap device." ? 

Done.

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:135: _throttled = False
On 2012/10/31 10:44:47, bulach wrote:
> nit: this should be a regular member in __init__ (afaict, here it's a static
> member)

Done.

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:151: def _readLog(self):
On 2012/10/31 10:44:47, bulach wrote:
> nit: _ReadLog

Done.

https://codereview.chromium.org/11352004/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:153: log =
self._adb.RunShellCommand("dmesg -c")
On 2012/10/31 10:44:47, bulach wrote:
> nit: single quotes on all strings here.

Done.

[commit-bot: I haz the power, 2012-10-31 15:14:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aberent@chromium.org/11352004/7001

[commit-bot: I haz the power, 2012-10-31 23:18:25]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-11-01 10:29:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aberent@chromium.org/11352004/7001

[commit-bot: I haz the power, 2012-11-01 13:44:44]

Change committed as 165367